Skip to content

Clarify interactive terminal checks #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
julman99 merged 1 commit into from
May 15, 2026
Merged

Clarify interactive terminal checks #28

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions src/main.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,14 @@ void print_and_exit_if_error(eatmemory_error if_error, char * error_message, eat
}
}

static bool output_is_terminal(void) {
return isatty(fileno(stdout));
}

static bool can_prompt_for_enter(void) {
return isatty(fileno(stdin)) && output_is_terminal();
}

struct terminal_progress {
bool active;
enum eatmemory_progress_stage stage;
Expand Down Expand Up @@ -177,7 +185,7 @@ int main(int argc, char *argv[]){

ap_free(parser);

bool show_progress = isatty(fileno(stdout));
bool show_progress = output_is_terminal();

print_memory_summary(&backend);
printf("\n");
Expand All @@ -204,7 +212,7 @@ int main(int argc, char *argv[]){
}

if(eaten.chunks){
if(timeout < 0 && isatty(fileno(stdin))) {
if(timeout < 0 && can_prompt_for_enter()) {
printf("Done, press ENTER to free the memory\n");
getchar();
} else if (timeout >= 0) {
Expand Down
Loading