meta: skip trash insert when rename overwrites a relinked hardlink - #7508
Open
BetterAndBetterII wants to merge 1 commit into
Open
BetterAndBetterII wants to merge 1 commit into
BetterAndBetterII wants to merge 1 commit into
Conversation
doRename lacked the hardlink trash-collision check doUnlink already had.
With trash enabled, unlink(link) keeps {parent}-{inode}-{name} in trash;
recreating the link and rename(file2, link) then UNIQUE-fails (EIO on
SQL) or overwrites and leaks nlink on Redis/TKV. Mirror unlink: if that
trash edge already exists, skip trash and decrement nlink.
Fixes juicedata#7502
|
|
Author
|
I have read the CLA Document and I hereby sign the CLA |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
doRenamewas missing the hardlink trash-collision check thatdoUnlinkalready had.unlink(link)keeps{parent}-{inode}-{name}in trash; recreating the link andrename(file2, link)then UNIQUE-fails (EIO on SQL) or overwrites and leaksnlinkon Redis/TKV.nlink.Fixes #7502
Test plan
go test ./pkg/meta -run TestSQLiteRenameOverRelinkedHardlink -count=1go test ./pkg/meta -run 'TestSQLiteClient|TestMemKVClient' -count=1