Export volume name to tikv metrics - #7480
Open
polyrabbit wants to merge 2 commits into
Open
polyrabbit wants to merge 2 commits into
polyrabbit wants to merge 2 commits into
Conversation
Signed-off-by: Changxin Miao <miaochangxin@step.ai>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7480 +/- ##
==========================================
+ Coverage 21.95% 22.00% +0.05%
==========================================
Files 31 31
Lines 24747 24805 +58
==========================================
+ Hits 5433 5459 +26
- Misses 18719 18749 +30
- Partials 595 597 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A TiKV cluster can serve metadata for multiple JuiceFS volumes. This PR exposes each JuiceFS volume name as a tenant identity in TiKV request-source metrics, which allows operators to monitor:
tikv_grpc_request_source_counter_vectikv_grpc_request_source_duration_vec/tikv_grpc_request_source_counter_vecWhen a TiKV cluster is under pressure, this makes it easier to quickly identify which volumes contribute most of the request traffic.
Following dashboard screenshot shows real per-volume source labels after this change:
