Repository navigation
Conversation
A syscall on such a mount never returns and DoWithTimeout abandons the goroutine that made it, so every retry strands one OS thread. DoPathWithTimeout refuses to start a check once maxInflightPerPath calls on the same path are still running.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1653
DoPathWithTimeoutisDoWithTimeoutwith a cap of 8 in-flight calls per path. Once a path reaches the cap, the next call returns an error instead of stranding another goroutine. A slot is freed when its call returns, so a mount that recovers needs no cleanup.Applied to the 23 call sites that only read a path. umount stays uncapped, since it has to work on a mount whose checks are all stuck.
GetDiskUsagehad no timeout at all and now takes one.Verified in kind with one hung mount and fd passing off, same base image one commit apart: