Conversation
dutor
approved these changes
Jul 15, 2026
There was a problem hiding this comment.
Pull request overview
This PR updates the FUSE bufferPool implementation to reduce lock contention by replacing the mutex-protected slice of pools with a concurrent sync.Map keyed by page-count.
Changes:
- Replaced
bufferPool’ssync.Mutex+[]*sync.Poolwith async.Map. - Updated
getPoolto useLoad/LoadOrStorefor concurrent pool initialization and retrieval.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
15
to
+16
| // For each page size multiple a list of slice pointers. | ||
| buffersBySize []*sync.Pool | ||
| buffersBySize sync.Map |
Comment on lines
21
to
+25
| func (p *bufferPool) getPool(pageCount int) *sync.Pool { | ||
| p.lock.Lock() | ||
| for len(p.buffersBySize) < pageCount+1 { | ||
| p.buffersBySize = append(p.buffersBySize, nil) | ||
| } | ||
| if p.buffersBySize[pageCount] == nil { | ||
| p.buffersBySize[pageCount] = &sync.Pool{ | ||
| New: func() interface{} { return make([]byte, pageSize*pageCount) }, | ||
| } | ||
| if pool_, ok := p.buffersBySize.Load(pageCount); ok { | ||
| return pool_.(*sync.Pool) | ||
| } | ||
| pool := p.buffersBySize[pageCount] | ||
| p.lock.Unlock() | ||
| return pool | ||
| pool_, _ := p.buffersBySize.LoadOrStore(pageCount, &sync.Pool{ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
optimize lock contention