feat(csi): make plugin directory configurable - #239
Open
sysakdemy wants to merge 1 commit into
Open
Conversation
Author
|
Hi, could you please review this PR when you have time? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR makes the CSI plugin directory configurable in the Helm chart instead of hardcoding
csi-plugins.A new Helm value is introduced:
pluginDir(default:csi-plugins)The CSI driver templates now use:
{{ .Values.kubeletDir }}/{{ .Values.pluginDir }}/{{ include "driverName" . }}/This preserves the current default behavior while allowing OpenShift/OKD environments to use
plugins.Closes #229
Why
On OKD/OpenShift 4, the kubelet plugin directory is typically:
Using the hardcoded
csi-pluginspath prevents CSI driver registration, which can lead to:csi-nodeCrashLoopBackOffChanges
pluginDirtovalues.yamlwith default valuecsi-pluginscsi-pluginspaths in CSI-related templates with{{ .Values.pluginDir }}pluginDirBackward compatibility
pluginDir: csi-plugins)pluginDircontinue to work as beforeHow to use
Default (no change required):
helm upgrade --install juicefs-csi . \ --namespace kube-systemOpenShift/OKD:
helm upgrade --install juicefs-csi . \ --namespace kube-system \ --set pluginDir=pluginsValidation
csi-pluginsis still used--set pluginDir=pluginsand confirmedpluginsis used in:DRIVER_REG_SOCK_PATH