Misc changes - #95
Open
jeroenbeijer wants to merge 5 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Jonti!
I hope you are doing well!
Here comes a pull request for a few miscellaneous changes.
I have added logic in SDRReceiver to be able to send both USB and LSB off of one VFO. This shaves a bit of CPU off. The MSK demodulator in jaero was not phase invariant so I switched to the already existing PreambleDetectorPhaseInvariant.
The locking bw is reloaded from the stored settings on restart but defaults back to say 900hz for 600bps. In some cases it is desirable to have a larger locking bw. I.e. I loose signal on 54W every day for a few hours. When it comes back up jaero does not always lock because it has moved away the locking bw. Also in the 8400 mode with a tight low pass filter, I find that 8400 yields better locking.
I have also added some more verbose output on the C channel call progress which some folks have asked about. I will put some details in that issue.
Finally a bunch of build stuff. I had issues building libcorrect and initially libacars with the latest cmake on windows. Dropped down to a lower version which I think now is only needed for libcorrect. On linux and Pi qcustomplot was causing issues due to a newer version. I included building the older version but maybe you know a more elegant way. It sounded like using the newer version was some effort but did not spend time on looking into it.
Maybe time to go to QT6 and CMake. May have some time to look into this in the next few month if you haven't already,
BR
Jeroen