Restore explicit non-loopback bind opt-in - #318
Merged
Merged
Conversation
This was referenced Jun 24, 2026
Owner
Author
Review RecordFrozen target: Panel:
Accepted findings fixed:
Rejected findings:
Validation after fixes:
Final status: all rerun reviewers clean; no unresolved blockers |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an explicit
[server] allow_non_loopback = trueopt-in so Beacon can bind to trusted private-network interfaces such as0.0.0.0:4600for direct Tailscale-IP dashboard access. The default remains loopback-only, and validation still rejects non-loopback hosts unless the opt-in is set.Closes #317
Refs #316
Validation
make fmt-check-> passedmake generate-check-> passed, updates=0go test ./internal/config ./internal/beaconcli-> passedmake test-> passedmake lint-> passedmake install-local INSTALL_DIR="$HOME/.local/bin"-> passedgit diff --check-> passedRisks
The security-sensitive behavior is the non-loopback bind path. The PR keeps the default at
127.0.0.1, requires an explicit opt-in for non-loopback hosts, and documents that anyone who can reach the bound interface can inspect Beacon dashboard/API/MCP data.Reviewer Notes
Focus on whether the opt-in is explicit enough, whether default validation remains restrictive, and whether the docs clearly distinguish proxy/VPN access from direct private-network binding. Backward compatibility was not generally required; the explicit user requirement is restoring direct Tailnet-IP access through a deliberate modern config path.