fix(build): enable zigfetch on Windows - #85
Conversation
Remove the exclusion for zigfetch on Windows targets. The unused local constant error in the generated C code has been resolved, making this workaround no longer necessary.
There was a problem hiding this comment.
Code Review
This pull request removes the Windows-specific exclusion for the zigfetch source in build.zig, which previously disabled it due to an unused local constant error. Since there are no review comments, I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
There was a problem hiding this comment.
Pull request overview
This PR updates the project’s build gating to allow the zigfetch binary to be built when targeting Windows, removing a prior Windows-only exclusion that was added as a workaround for a C codegen warning/error.
Changes:
- Removed the
sourceSupported()early-return that skipped buildingzigfetchfortarget_os == .windows.
Switch matrix definition to explicit include for both CI and release workflows. This enables accurate OS-target mapping and avoids redundant builds on unsupported platforms. It improves build clarity and maintainability as more platforms are added.
Remove the exclusion for zigfetch on Windows targets. The unused local constant error in the generated C code has been resolved, making this workaround no longer necessary.