Skip to content

fix(build): enable zigfetch on Windows - #85

Open
jiacai2050 wants to merge 2 commits into
mainfrom
fix-wins
Open

fix(build): enable zigfetch on Windows#85
jiacai2050 wants to merge 2 commits into
mainfrom
fix-wins

Conversation

@jiacai2050

Copy link
Copy Markdown
Owner

Remove the exclusion for zigfetch on Windows targets. The unused local constant error in the generated C code has been resolved, making this workaround no longer necessary.

Remove the exclusion for zigfetch on Windows targets. The unused local
constant error in the generated C code has been resolved, making this
workaround no longer necessary.
Copilot AI review requested due to automatic review settings July 18, 2026 02:20

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the Windows-specific exclusion for the zigfetch source in build.zig, which previously disabled it due to an unused local constant error. Since there are no review comments, I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the project’s build gating to allow the zigfetch binary to be built when targeting Windows, removing a prior Windows-only exclusion that was added as a workaround for a C codegen warning/error.

Changes:

  • Removed the sourceSupported() early-return that skipped building zigfetch for target_os == .windows.

Copilot AI review requested due to automatic review settings July 18, 2026 14:42

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot AI review requested due to automatic review settings July 18, 2026 14:59

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Switch matrix definition to explicit include for both CI and release
workflows. This enables accurate OS-target mapping and avoids
redundant builds on unsupported platforms. It improves build clarity
and maintainability as more platforms are added.
Copilot AI review requested due to automatic review settings July 18, 2026 15:02

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants