refactor [CAT-15]: update request button style#6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CAT-15: Style item-level request buttons in NDE
The "Request from JH" button under Locations was rendering as plain text — not very clickable-looking. This brings it visually in line with the styled request buttons in
current Catalyst (JHU blue, bold white text, rounded).
Changes
src/assets/css/custom.csstargetingnde-location-item-service-button button#0072cebackground, white bold text,border-radius: 1em, hover darkens to#002d720.5em 1.25em) andwhite-space: nowrapso the label fits the narrower NDE column without wrapping to two linesReference for colors / shape:
01JHU_INST-JHU/css/buttons.cssin the legacy primo-customization-package repo.Notes
!importanton a few properties to override Material's defaultmat-buttonstyles. Open to a cleaner approach if anyone has one.nde-location-item-service-button), so it shouldn't bleed onto other Material buttons elsewhere on the page.Testing
npm run start:proxyagainst the JHU sandbox envCloses CAT-15.