Skip to content

Fix bugs when working with JRebel#51

Open
alex-lx wants to merge 4 commits into
jhalterman:masterfrom
alex-lx:master
Open

Fix bugs when working with JRebel#51
alex-lx wants to merge 4 commits into
jhalterman:masterfrom
alex-lx:master

Conversation

@alex-lx

@alex-lx alex-lx commented Mar 9, 2019

Copy link
Copy Markdown

Ignore JRebel inserted methods in getMemberRef
Resolve issue: #50

alex-lx added 2 commits March 9, 2019 22:21
Ignore JRebel inserted methods in getMemberRef
@codecov-io

codecov-io commented Apr 26, 2019

Copy link
Copy Markdown

Codecov Report

Merging #51 into master will decrease coverage by 1.64%.
The diff coverage is 20%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #51      +/-   ##
============================================
- Coverage     76.71%   75.07%   -1.65%     
- Complexity      105      106       +1     
============================================
  Files             2        2              
  Lines           335      345      +10     
  Branches         98      100       +2     
============================================
+ Hits            257      259       +2     
- Misses           34       40       +6     
- Partials         44       46       +2
Impacted Files Coverage Δ Complexity Δ
...rc/main/java/net/jodah/typetools/TypeResolver.java 78.14% <20%> (-2%) 98 <1> (+1)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0bd6f1f...94e2c7d. Read the comment docs.

@jhalterman

Copy link
Copy Markdown
Owner

I realize this might be better if it's a configuration, so that we don't have to hardcode JRebel things that might change, instead JRebel users can configure them. Ex:

// Filters methods that might be matched when resolving lambda type arguments
TypeResolver.addLambdaMemberFilter(Predicate<Member> lambdaMemberFilter)

Thoughts?

@alex-lx

alex-lx commented Apr 27, 2019

Copy link
Copy Markdown
Author

Got it. I've added the addLambdaMemberFilter method to make the client add a custom filter.

PTAL

The CI failed cause by install-jdk.sh, would you like to check it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants