Fix bugs when working with JRebel#51
Open
alex-lx wants to merge 4 commits into
Open
Conversation
Ignore JRebel inserted methods in getMemberRef
Codecov Report
@@ Coverage Diff @@
## master #51 +/- ##
============================================
- Coverage 76.71% 75.07% -1.65%
- Complexity 105 106 +1
============================================
Files 2 2
Lines 335 345 +10
Branches 98 100 +2
============================================
+ Hits 257 259 +2
- Misses 34 40 +6
- Partials 44 46 +2
Continue to review full report at Codecov.
|
Owner
|
I realize this might be better if it's a configuration, so that we don't have to hardcode JRebel things that might change, instead JRebel users can configure them. Ex: // Filters methods that might be matched when resolving lambda type arguments
TypeResolver.addLambdaMemberFilter(Predicate<Member> lambdaMemberFilter)Thoughts? |
Author
|
Got it. I've added the PTAL The CI failed cause by |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ignore JRebel inserted methods in getMemberRef
Resolve issue: #50