Run make upgrade-klone and make generate#792
Merged
SgtCoDFish merged 3 commits intomasterfrom Apr 21, 2026
Merged
Conversation
Signed-off-by: Ashley Davis <ashley.davis@cyberark.com>
Previously, we had a custom unit test target in this repo but it has now been added to the upstream helm makefile-module. So, swap to that Signed-off-by: Ashley Davis <ashley.davis@cyberark.com>
See comment in tests.yaml for details Signed-off-by: Ashley Davis <ashley.davis@cyberark.com>
SgtCoDFish
commented
Apr 21, 2026
Contributor
Author
There was a problem hiding this comment.
self-review: this file is definitely not needed in this repo (it's a cert-manager thing we pull in).
But, it's not doing any harm and the actual OWNERS file is massively out of date too. I'm leaving cleaning that up as a separate thing for the future and ignoring it here.
inteon
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mostly, this is to bump go, but it also brings in a new upstream helm unit-test target which requires a few updates and some cleanup of this repository's old targets.
Important: I've also gated the ark-test-e2e behind a label because it's so consistently flaky (see the history of runs of #790 for motivation, and see the comment I added to the ark-test-e2e job)