Change BatchSummaryCollector default y-axis scaling to independent axes#392
Merged
Merged
Conversation
- Add _default_plotter_arguments to BatchSummaryCollector class
- Set match_axes to False by default for better usability
- Matching axes only suitable for specific plot combinations
- Users can still override with plotter_arguments={'match_axes': True}
Fixes #391
Co-authored-by: Jan Petter Maehlen <jepe@ife.no>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes the default y-axis scaling behavior for
BatchSummaryCollectorfrom matching axes across subplots to independent axes.Problem
The
BatchSummaryCollectorcurrently defaults tomatch_axes=True, which forces all subplots to share the same y-axis scale. This behavior is only suitable for specific plot combinations and is not appropriate for the majority of use cases where different variables (e.g., capacity, voltage, efficiency) have different scales.Solution
Added
_default_plotter_argumentsto theBatchSummaryCollectorclass withmatch_axesset toFalse:Impact
plotter_arguments={"match_axes": True}BatchSummaryCollector, not other collectors likeBatchCyclesCollectororBatchICACollectorTesting
The change follows the existing pattern used by other collectors in the codebase (documented in the class-level comments about three levels of argument precedence).
Closes #391