test: add CellpyLimits to cellpy-core parity contract (STEP-08)#390
Merged
Conversation
CellpyLimits (step-type detection thresholds) is now mirrored in cellpycore.legacy, so include it in the field-for-field parity test alongside the headers/units classes to guard against silent drift. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CellpyLimits(step-type detection thresholds) is mirrored verbatim incellpycore.legacy; add it toSHARED_CLASSESintests/test_core_settings_parity.pyso the field-for-field parity contract now guards limits alongside headers/units.Context:
make_step_tablealready delegates fully tocore.make_core_step_table, so no dead step-table engine code remains incellpyto retire — this test was the last open STEP-08 item.Test plan
uv run pytest tests/test_core_settings_parity.py -q→ 5 passed (was 4)uv run pytest tests/ -k "step_table or steptable or make_step" -q→ 9 passed (step-table tests stay green via the core seam)Made with Cursor