Repository navigation
Follow ~/.python_search/theme in ps_ui; remove the Python terminal UI - #64
Merged
Merged
Conversation
ps_ui now picks dark/light from ~/.python_search/theme (after PS_UI_THEME, before the time-of-day fallback), re-read every frame so a running daemon switches live when a system-wide theme switch writes the file. The Kitty-based term_ui and its supporting modules (QueryLogic, BM25 search, search actions, Python themes) are removed; `python_search search` / `pys` now open ps_ui. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
The ubuntu-22.04 runner ships Python 3.10, which the project's python = ">=3.12,<=3.14" constraint rejects, so the Tests workflow has failed at poetry install on every run since September. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
CI's poetry install refused the stale lock file (pyproject.toml changed significantly since poetry.lock was last generated). Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
getch 1.0 is a Python 2 C extension that no longer builds on 3.12, and only the removed terminal UI used it. poetry.lock was also out of sync with pyproject.toml (missing pysimplegui), which made `poetry install` abort in CI. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Tests import SystemPaths, which requires PYTHON_SEARCH_PATH in ~/.config/python_search/config. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
SystemPaths and the entries loader raise when ~/.config/python_search/config or current_project are missing, so test collection errored on the runner. Point them at the checkout and at a project made from the bundled template. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
ubuntu-22.04's apt ripgrep (13.0) fails to find the entry key declaration in test_entries_editor_finds_key_declaration_not_other_mentions; 24.04 ships 14.1. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
re.escape also escapes spaces, and ripgrep < 14 (Ubuntu 22.04's 13.x) rejects "\ " as an unrecognized escape, so edit_key found nothing for any key with a space and fell back to the default file. Escape only Rust regex metacharacters. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dark_mode_now()reads~/.python_search/theme(dark/light). Order isPS_UI_THEME, then the file, then the time of day as before. It's checked every frame while the launcher is visible, so a running daemon switches as soon as an external theme switcher writes the file.terminal_ui.py,kitty_for_search_ui.py,QueryLogic.py,bm25_search.py,search_actions.py,python_search/apps/theme/, their tests, theterm_uiscript andsetup_term_ui_logger.python_search search/pysnow runps_ui show.KittyTerminal.get_kitty_cmdusesSystemPaths.KITTY_BINNARYdirectly.term_uiand document the theme order.actions/setup-python, regenerate the stalepoetry.lock, install ripgrep, and write~/.config/python_search/configbefore pytest.Test plan
pytest tests: 99 passedcargo build --release -p ps-uips-ui.service, and the theme file is written by the system theme switchlight/darkto~/.python_search/theme🤖 Generated with Claude Code