[release-1.27] stats: utilize expiration#7063
Open
tedjpoole wants to merge 2 commits into
Open
Conversation
Change-Id: I97c10eac08443566eca6f53dc73b86c2e51fa095 Signed-off-by: Kuat Yessenov <kuat@google.com> Signed-off-by: Ted Poole <tpoole@redhat.com>
|
😊 Welcome @tedjpoole! This is either your first contribution to the Istio proxy repo, or it's been You can learn more about the Istio working groups, Code of Conduct, and contribution guidelines Thanks for contributing! Courtesy of your friendly welcome wagon. |
istio-testing
added
the
size/L
istio-testing
added
the
do-not-merge/work-in-progress
Author
|
Waiting for envoyproxy/envoy#45316 to land, to get the ENVOY_SHA |
tedjpoole
requested review from
kyessenov and
zirain
and removed request for
kyessenov
Update ENVOY_SHA to the tip of envoyproxy/envoy release/v1.35, which includes the backported stats metric expiry (#40395) and stats number limiting (#42168) from envoyproxy/envoy#45316. Signed-off-by: Ted Poole <tpoole@redhat.com>
istio-testing
removed
the
do-not-merge/work-in-progress
Member
|
@tedjpoole was this intentionally opened? this is not an appropriate change to backport |
Author
|
Hi @howardjohn, yes — we're hitting OOM kills in waypoint proxies on 1.27 due to unbounded metric growth (istio/istio#58532) and were hoping to bring over the stats eviction support that landed in 1.28. Happy to take guidance on the right approach here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Back port of #6529
This is part of a coordinated backport to back port stats eviction support from Envoy 1.36 / Istio 1.28 to Envoy 1.35 / Istio 1.27, to address unbounded metric memory growth in waypoint proxies. The full set of changes to be back ported across repositories: