feat(explorer): improve transaction blocks on the address account pages - #259
Merged
Conversation
|
Deployment failed with the following error: View Documentation: https://vercel.com/docs/accounts/team-members-and-roles |
|
The latest updates on your projects. Learn more about Vercel for GitHub. 4 Skipped Deployments
|
|
Deployment failed with the following error: View Documentation: https://vercel.com/docs/accounts/team-members-and-roles |
|
Deployment failed with the following error: View Documentation: https://vercel.com/docs/accounts/team-members-and-roles |
|
Deployment failed with the following error: View Documentation: https://vercel.com/docs/accounts/team-members-and-roles |
|
Deployment failed with the following error: View Documentation: https://vercel.com/docs/accounts/team-members-and-roles |
Juligs
changed the title
Juligs
marked this pull request as ready for review
July 17, 2026 15:46
|
Deployment failed with the following error: View Documentation: https://vercel.com/docs/accounts/team-members-and-roles |
evavirseda
requested changes
Jul 21, 2026
evavirseda
reviewed
Jul 21, 2026
evavirseda
requested changes
Jul 27, 2026
evavirseda
requested changes
Jul 28, 2026
Comment on lines
57
to
59
| const isSender = txn.transaction?.data.sender === address; | ||
| return direction === TransactionDirection.Sent ? isSender : !isSender; | ||
| } |
Member
There was a problem hiding this comment.
Send is showing a positive balance change, and its a bit confusing 🙈
Suggested change
| const isSender = txn.transaction?.data.sender === address; | |
| return direction === TransactionDirection.Sent ? isSender : !isSender; | |
| } | |
| const balanceChange = getIotaBalanceChangeForAddress(txn, address); | |
| const isReceived = | |
| balanceChange && balanceChange.amount !== '0' | |
| ? Number(balanceChange.amount) > 0 | |
| : txn.transaction?.data.sender !== address; | |
| return direction === TransactionDirection.Sent ? !isReceived : isReceived; | |
| } |
| {typeLabel} | ||
| </span> | ||
| <span className="text-body-sm text-iota-primary-30 dark:text-iota-primary-80"> | ||
| {functionName ?? formatDigest(digest)} |
Member
There was a problem hiding this comment.
removing the digest from some transactions isnt a good idea 🙈 because users lose the ability to click directly and navigate to the transaction
what i was suggesting (#259 (comment) and in slack) was simply adding an additional column for the function, rather than replacing the digest
Suggested change
| {functionName ?? formatDigest(digest)} | |
| {formatDigest(digest)} |
Comment on lines
+89
to
+104
| /** | ||
| * Name of the last Move function called in a programmable transaction block, if any (e.g. | ||
| * `request_add_stake`). Transactions with no Move call (plain transfers) have none. | ||
| */ | ||
| export function getTransactionFunctionName(txn: IotaTransactionBlockResponse): string | undefined { | ||
| const transaction = txn.transaction?.data.transaction; | ||
| if (transaction?.kind !== 'ProgrammableTransaction') { | ||
| return undefined; | ||
| } | ||
| const moveCalls = transaction.transactions | ||
| .filter( | ||
| (command): command is { MoveCall: MoveCallIotaTransaction } => 'MoveCall' in command, | ||
| ) | ||
| .map((command) => command.MoveCall); | ||
| return moveCalls.at(-1)?.function; | ||
| } |
Member
There was a problem hiding this comment.
Suggested change
| /** | |
| * Name of the last Move function called in a programmable transaction block, if any (e.g. | |
| * `request_add_stake`). Transactions with no Move call (plain transfers) have none. | |
| */ | |
| export function getTransactionFunctionName(txn: IotaTransactionBlockResponse): string | undefined { | |
| const transaction = txn.transaction?.data.transaction; | |
| if (transaction?.kind !== 'ProgrammableTransaction') { | |
| return undefined; | |
| } | |
| const moveCalls = transaction.transactions | |
| .filter( | |
| (command): command is { MoveCall: MoveCallIotaTransaction } => 'MoveCall' in command, | |
| ) | |
| .map((command) => command.MoveCall); | |
| return moveCalls.at(-1)?.function; | |
| } | |
| /** | |
| * The last Move call in a programmable transaction block, if any (e.g. `request_add_stake` on | |
| * the staking package). Transactions with no Move call (plain transfers) have none. | |
| */ | |
| export function getLastMoveCall( | |
| txn: IotaTransactionBlockResponse, | |
| ): MoveCallIotaTransaction | undefined { | |
| const transaction = txn.transaction?.data.transaction; | |
| if (transaction?.kind !== 'ProgrammableTransaction') { | |
| return undefined; | |
| } | |
| const moveCalls = transaction.transactions | |
| .filter( | |
| (command): command is { MoveCall: MoveCallIotaTransaction } => 'MoveCall' in command, | |
| ) | |
| .map((command) => command.MoveCall); | |
| return moveCalls.at(-1); | |
| } |
| </span> | ||
| <span className="text-body-sm text-iota-primary-30 dark:text-iota-primary-80"> | ||
| {formatDigest(digest)} | ||
| {functionName ?? formatDigest(digest)} |
Member
There was a problem hiding this comment.
Suggested change
| {functionName ?? formatDigest(digest)} | |
| {formatDigest(digest)} |
| </TableCellText> | ||
| </TableCellBase> | ||
| ); | ||
| }, |
Member
There was a problem hiding this comment.
Suggested change
| }, | |
| { | |
| header: 'Function', | |
| accessorKey: 'function', | |
| cell: ({ row }) => { | |
| const kind = row.original.transaction?.data.transaction.kind; | |
| const kindLabel = kind === 'ProgrammableTransaction' ? 'Programmable Tx' : '--'; | |
| const moveCall = getLastMoveCall(row.original); | |
| return ( | |
| <TableCellBase> | |
| <div className="flex flex-col"> | |
| <span className="text-label-lg text-iota-neutral-40 dark:text-iota-neutral-60"> | |
| {kindLabel} | |
| </span> | |
| {moveCall && ( | |
| <ObjectLink | |
| objectId={`${moveCall.package}?module=${moveCall.module}`} | |
| copyText={moveCall.package} | |
| showAddressAlias={false} | |
| label={moveCall.function} | |
| className="text-body-sm" | |
| /> | |
| )} | |
| </div> | |
| </TableCellBase> | |
| ); | |
| }, | |
| }, |
|
This pull request has been deployed to Vercel.
|
|
This pull request has been deployed to Vercel.
|
|
This pull request has been deployed to Vercel.
|
|
This pull request has been deployed to Vercel.
|
evavirseda
approved these changes
Jul 28, 2026
VmMad
approved these changes
Jul 28, 2026
…-page' into feat/improve-transaction-blocks-on-the-address-account-pages
VmMad
force-pushed
the
feat/improve-transaction-blocks-on-the-address-account-pages
branch
from
July 28, 2026 16:41
d572202 to
c78f585
Compare
|
This pull request has been deployed to Vercel.
|
VmMad
deleted the
feat/improve-transaction-blocks-on-the-address-account-pages
branch
July 28, 2026 17:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #250