Fix 500 error on contact create with invalid ident - #2945
Open
maricavor wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix RegNoValidator and NationalIdValidator using Country.new('EE') as hash keys — hash lookup never matched because Country lacks eql?/hash, making both validators no-ops. Replaced with string keys and record.country_code.
Fix maybe_validate_ident ignoring identifier.valid? result — invalid ident (e.g. EE102946871) passed through to maybe_company_is_relevant, which made a SOAP call to the Business Registry causing 'Unparseable integer' fault and EPP 2400 (Internal Server Error) instead of EPP 2005 (Parameter value syntax error).
Add early @error flag and EPP error generation in maybe_validate_ident to short-circuit before the SOAP call.
Add @error guard to maybe_company_is_relevant to skip the SOAP call when prior validation has already failed.