[GSoC 2026] chatbot: harden jobs-vs-investigations routing + accept null filter args (Refs #3843)#3844
Merged
Merged
Conversation
…ull filter args — Refs #3843
mlodic
approved these changes
Jul 7, 2026
Contributor
Author
|
Thanks for the review! CI is green and the branch is up to date with develop. I don't have merge rights on develop — could you squash-merge when you have a moment? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #3843.
What
Two coupled changes; the second is the null-arg gap the first exposed.
qwen2.5:3b, temp=0) mis-routed several "jobs" phrasingsto
list_investigations. Strengthen thesearch_jobsside ofsystem_prompt.txtonly (broaden thecue with the failing phrasings incl. the verbatim "what jobs do I have?"; one
[Rules]disambiguation line).
list_investigationscue untouched, so its routing controls are unaffected.search_jobs(query=None, ...);the
query: str = ""/status: str = ""signatures rejected the explicitNone, so the answerwas still empty. Widen
query/statustoOptional[str] = Noneonsearch_jobsandlist_investigations(signature only — the bodies already guard withif query:/if status:,and
visible_for_user(user)scoping is unchanged).Evidence (same-session A/B/C, tool-selection reliability harness)
Correct = expected tool called; "delivered" = the actual job list was returned. Warm n=8, cold n=2.
Zero regressions; all controls hold;
analyze_observablekeeps its M-1action_requiredpreview.171 chatbot unit tests green.
Data-isolation note
The tool change is a type-only widening of already-optional filter args; the querysets stay scoped by
visible_for_user(user)and the bodies are unchanged, so anullfilter behaves exactly like anempty one (no widening). New tool tests assert isolation still holds under
query=None/status=None(another user's RED job / a non-shared investigation stay hidden).
agent-data-isolation-reviewerwasnot spawnable in the authoring session; the review was done inline.