Skip to content

fix: Added exception re-raise in httpx method overwrites#867

Open
Rafal-Chrzanowski-IBM wants to merge 4 commits intoinstana:mainfrom
Rafal-Chrzanowski-IBM:main
Open

fix: Added exception re-raise in httpx method overwrites#867
Rafal-Chrzanowski-IBM wants to merge 4 commits intoinstana:mainfrom
Rafal-Chrzanowski-IBM:main

Conversation

@Rafal-Chrzanowski-IBM
Copy link
Copy Markdown

Fixes #866.

Added exception re-raise after exception has been recorded.
Previously pylance showed the following warning:

Function with declared return type "Response" must return value on all code paths
  "None" is not assignable to "Response"

Currently this warning isn't visible anymore.

@Rafal-Chrzanowski-IBM Rafal-Chrzanowski-IBM requested a review from a team as a code owner April 22, 2026 08:22
@github-actions

This comment was marked as resolved.

Signed-off-by: Rafal Chrzanowski <Rafal.Chrzanowski@ibm.com>
Comment thread src/instana/instrumentation/httpx.py
Signed-off-by: Rafal Chrzanowski <Rafal.Chrzanowski@ibm.com>
Signed-off-by: Rafal Chrzanowski <Rafal.Chrzanowski@ibm.com>
Copy link
Copy Markdown
Contributor

@GSVarsha GSVarsha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few suggestions

Comment thread src/instana/instrumentation/httpx.py Outdated
Comment thread src/instana/instrumentation/httpx.py Outdated
Comment thread src/instana/instrumentation/httpx.py
Comment thread src/instana/instrumentation/httpx.py
@GSVarsha GSVarsha added this to the H1-2026 milestone Apr 27, 2026
@GSVarsha GSVarsha added the fix label Apr 27, 2026
Co-authored-by: Varsha <52667690+GSVarsha@users.noreply.github.com>
Signed-off-by: Rafal-Chrzanowski-IBM <Rafal.Chrzanowski@ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: httpx handle_request_with_instana returns None instead of re-raising exception

2 participants