Repository navigation
Step 1 for #211: Move support to OTP28+ - #212
Merged
Merged
Conversation
elbrujohalcon
force-pushed
the
brujo.211.otp28
branch
from
September 29, 2026 09:23
efb98c6 to
bdf0354
Compare
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
OpenAPI version and parameter-reference regressions can produce invalid or incomplete specifications.
Review effort: Balanced
Findings: 2
Open (4)
What changed in this PR
Raises the project baseline to OTP 28+, modernizing dependencies, tooling, types, comprehensions, formatting, tests, and examples.
Changes:
- Upgrades OTP, Cowboy, Ranch, Trails, Mixer, CI actions, and development tooling.
- Adopts nominal types, binary string sigils, strict/map comprehensions, and erlfmt.
- Reformats application, test, and example sources.
| File | Description |
|---|---|
.github/workflows/ci.yml |
Updates CI matrix, actions, and formatter. |
elvis.config |
Enables stricter lint rules. |
rebar.config |
Raises OTP baseline and updates tooling/dependencies. |
rebar.lock |
Locks upgraded dependencies. |
src/cowboy_swagger.app.src |
Updates application metadata. |
src/cowboy_swagger.erl |
Modernizes types, strings, and comprehensions. |
src/cowboy_swagger_handler.erl |
Reformats route construction. |
src/cowboy_swagger_json_handler.erl |
Adds nominal handler types. |
src/cowboy_swagger_redirect_handler.erl |
Makes handler state opaque. |
test/cover.spec |
Removes explicit coverage-module configuration. |
test/cowboy_swagger_handler_SUITE.erl |
Modernizes handler integration tests. |
test/cowboy_swagger_server_spec_SUITE.erl |
Modernizes per-server specification tests. |
test/cowboy_swagger_SUITE.erl |
Modernizes core specification tests. |
test/cowboy_swagger_test_utils.erl |
Adds nominal test utility types. |
test/example.app |
Reformats test application metadata. |
test/example.erl |
Updates application behavior and formatting. |
test/example_default.erl |
Updates types and binary literals. |
test/example_description_handler.erl |
Modernizes metadata literals. |
test/example_echo_handler.erl |
Modernizes metadata and response literals. |
test/example_sup.erl |
Corrects the supervisor return type. |
test/host1_handler.erl |
Modernizes host-handler metadata. |
test/multiple_hosts_servers_example.app |
Reformats multi-host application metadata. |
test/multiple_hosts_servers_example.erl |
Updates application behavior and formatting. |
example/config/sys.config |
Reformats example configuration. |
example/rebar.config |
Raises OTP baseline and updates tooling. |
example/rebar.lock |
Locks upgraded example dependencies. |
example/src/example.app.src |
Reformats example application metadata. |
example/src/example.erl |
Reformats application startup code. |
example/src/example_default.erl |
Reformats callback exports. |
example/src/example_description_handler.erl |
Reformats description metadata. |
example/src/example_echo_handler.erl |
Reformats echo metadata. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
The core JSON backend and supported runtime floor change across the public API, dependencies, tests, and examples, warranting final human validation.
Review effort: Balanced
Findings: None
Resolved since last review (2)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


No description provided.