Skip to content

Step 1 for #211: Move support to OTP28+ - #212

Merged
elbrujohalcon merged 5 commits into
mainfrom
brujo.211.otp28
Sep 30, 2026
Merged

elbrujohalcon merged 5 commits into
mainfrom
brujo.211.otp28

Conversation

@elbrujohalcon

Copy link
Copy Markdown
Member

No description provided.

@elbrujohalcon elbrujohalcon added this to the 3.0.0 milestone Sep 29, 2026
@elbrujohalcon elbrujohalcon self-assigned this Sep 29, 2026
@elbrujohalcon elbrujohalcon changed the title Fix #211: Move support to OTP28+ Step 1 for #211: Move support to OTP28+ Sep 29, 2026
@elbrujohalcon
elbrujohalcon requested a balanced review from Copilot September 29, 2026 11:39

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

OpenAPI version and parameter-reference regressions can produce invalid or incomplete specifications.

Review effort: Balanced
Findings: 2 Medium severity · 2 Low severity

Open (4)
What changed in this PR

Raises the project baseline to OTP 28+, modernizing dependencies, tooling, types, comprehensions, formatting, tests, and examples.

Changes:

  • Upgrades OTP, Cowboy, Ranch, Trails, Mixer, CI actions, and development tooling.
  • Adopts nominal types, binary string sigils, strict/map comprehensions, and erlfmt.
  • Reformats application, test, and example sources.
File Description
.github/​workflows/​ci.yml Updates CI matrix, actions, and formatter.
elvis.config Enables stricter lint rules.
rebar.config Raises OTP baseline and updates tooling/dependencies.
rebar.lock Locks upgraded dependencies.
src/​cowboy_swagger.app.src Updates application metadata.
src/​cowboy_swagger.erl Modernizes types, strings, and comprehensions.
src/​cowboy_swagger_handler.erl Reformats route construction.
src/​cowboy_swagger_json_handler.erl Adds nominal handler types.
src/​cowboy_swagger_redirect_handler.erl Makes handler state opaque.
test/​cover.spec Removes explicit coverage-module configuration.
test/​cowboy_swagger_handler_SUITE.erl Modernizes handler integration tests.
test/​cowboy_swagger_server_spec_SUITE.erl Modernizes per-server specification tests.
test/​cowboy_swagger_SUITE.erl Modernizes core specification tests.
test/​cowboy_swagger_test_utils.erl Adds nominal test utility types.
test/​example.app Reformats test application metadata.
test/​example.erl Updates application behavior and formatting.
test/​example_default.erl Updates types and binary literals.
test/​example_description_handler.erl Modernizes metadata literals.
test/​example_echo_handler.erl Modernizes metadata and response literals.
test/​example_sup.erl Corrects the supervisor return type.
test/​host1_handler.erl Modernizes host-handler metadata.
test/​multiple_hosts_servers_example.app Reformats multi-host application metadata.
test/​multiple_hosts_servers_example.erl Updates application behavior and formatting.
example/​config/​sys.config Reformats example configuration.
example/​rebar.config Raises OTP baseline and updates tooling.
example/​rebar.lock Locks upgraded example dependencies.
example/​src/​example.app.src Reformats example application metadata.
example/​src/​example.erl Reformats application startup code.
example/​src/​example_default.erl Reformats callback exports.
example/​src/​example_description_handler.erl Reformats description metadata.
example/​src/​example_echo_handler.erl Reformats echo metadata.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread src/cowboy_swagger.erl Outdated
Comment thread src/cowboy_swagger.erl Outdated
Comment thread test/cowboy_swagger_SUITE.erl
Comment thread test/cowboy_swagger_server_spec_SUITE.erl
@elbrujohalcon elbrujohalcon changed the title Step 1 for #211: Move support to OTP28+ Fix #211: Move support to OTP28+ Sep 29, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

Type contracts contradict supported atom inputs, and README examples specify invalid OpenAPI versions.

Review effort: Balanced
Findings: 1 Medium severity · 1 Low severity

Open (2)
Resolved since last review (4)

Comment thread src/cowboy_swagger.erl
Comment thread README.md Outdated

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🔵 Needs a closer look

The core JSON backend and supported runtime floor change across the public API, dependencies, tests, and examples, warranting final human validation.

Review effort: Balanced
Findings: None

Resolved since last review (2)

@elbrujohalcon elbrujohalcon changed the title Fix #211: Move support to OTP28+ Step 1 for #211: Move support to OTP28+ Sep 29, 2026
@elbrujohalcon
elbrujohalcon merged commit a29d339 into main Sep 30, 2026
3 checks passed
@elbrujohalcon
elbrujohalcon deleted the brujo.211.otp28 branch September 30, 2026 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants