FIX(py/client): align async / sync client methods, remove default values in test seed, etc#166
Open
hon-gyu wants to merge 6 commits into
Open
FIX(py/client): align async / sync client methods, remove default values in test seed, etc#166hon-gyu wants to merge 6 commits into
test seed, etc#166hon-gyu wants to merge 6 commits into
Conversation
| seed: Optional[int] = None, | ||
| timeout: Optional[float] = None, | ||
| ) -> simple_api_pb2.TestRes: | ||
| seed = seed or 0 |
Collaborator
There was a problem hiding this comment.
I think we should not set the default seed in the client package, but rely on the server side default. I think the seed is currently not optional, but it's fine to make it optional.
Contributor
Author
There was a problem hiding this comment.
I agree. The async client changes here are purely to mirror sync client (which sets default seed if not provided). I've removed the default-setting behavior in both clients. cecd690
hon-gyu
changed the title
test seed, etc
wintersteiger
approved these changes
Jun 22, 2026
wintersteiger
left a comment
wintersteiger
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, many thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minor fixes