This repository was archived by the owner on Feb 22, 2026. It is now read-only.
Fix JSX key attribute clobbering detected value#1042
Open
comp615 wants to merge 1 commit into
Open
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1042 +/- ##
==========================================
- Coverage 95.40% 95.35% -0.05%
==========================================
Files 11 10 -1
Lines 1937 1918 -19
==========================================
- Hits 1848 1829 -19
Misses 89 89 ☔ View full report in Codecov by Sentry. |
Member
|
@comp615 I have mixed feeling about this as some people might be relying on the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why am I submitting this PR
React components have a protected attribute "key" which can seemingly clobber the detected/parsed i18n key due to a naming conflict.
Does it fix an existing ticket?
Yes #1038
Checklist
yarn test(see details here)