Feat: find/replace - #384
Open
GrahameGW wants to merge 3 commits into
Open
Conversation
|
@GrahameGW is attempting to deploy a commit to the Hyperlink Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Nice this is really cool! Will get @jaredpereira to review more closely but a couple things from quick test:
|
Contributor
Author
|
Ah yeah, I'll get those fixed up ASAP. Thanks for checking. |
Contributor
Author
|
@bschlagel fixed them up, also tweaked the "mobile" behavior so the modal goes to the bottom of the screen on narrow views. I don't technically think you can access this via mobile since it's purely keyboard shortcut, but if you guys want a menu button we could definitely add one, just let me know what icon you want me to use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A find/replace modal in the editor to make it easy to find and replace text.