Skip to content

Last updated time for a session should be updated on user input #57

Open

Description

@shadaj
No description provided.

Activity

  1. kaluli123123 commented on Nov 3, 2026

    @kaluli123123

    Implemented in draft PR #182 (commit 63afcdd5f0bd6419ffc53f73e242f286d478b8df).

    • Root cause: Activity timestamps were updated only when a completion finished; set_last_updated also omitted the session-change notification.
    • Fix boundary: Persist activity on UserInput before its echo, and notify session metadata subscribers after timestamp changes.
    • Focused checks: 2 new user_input regressions passed, covering persistence before completion and SessionsUpdated without completion.
    • Runtime proof: Actual client-channel cargo-run smoke emitted SessionsUpdated before model completion: last_updated=2026-11-03T09:41:34.685148+00:00, followed by ResponseDone.
    • Full all-target test run: 357 passed, 7 failed, 0 ignored. The exact same seven TUI snapshots fail on clean base 1abc6fcff1f186124f924b56aa92c3a3684c90c5 (355 passed, 7 failed). No baselines or tolerances were changed.
    • Doctests: 45 passed, 1 ignored. Rust formatting, workspace Clippy with warnings denied, and all-target compilation passed. Independent read-only review found no blocking issues.

    I am maintaining this proposed fix. The PR remains Draft, not ready or merged: full checks are not green, remote CI currently lists no checks, and maintainer review remains outstanding. The repository script skipped docs/UI Prettier because node_modules are absent; optional browser e2e and THIRD-PARTY verification were not reached after the test gate failed. No live model account was used. No merge, Issue closure, or deployment has been performed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions