Skip to content

bug(infinity-agents-cli): waiting-for-choice modal broken when multiple sub-agents trigger it at the same time? #175

Open

Description

@MingweiSamuel
No description provided.

Activity

  1. kaluli123123 commented on Nov 3, 2026

    @kaluli123123

    Implemented in draft PR #184 (commit 7e459c9aff97116f28412e6db282cf7917ff5dc4).

    • Root cause: Child observers inherit root subscribers, but choice answers previously searched only attached_thread_id and silently lost child answers.
    • Fix boundary: Look up pending choices across the attached root session and its descendants, preserving cross-session isolation without changing the protocol.
    • Focused checks: rap_callback_flow: 4 passed, including 2 new root/child connection routing regressions.
    • Runtime proof: Actual cargo-run callback/client/HTTP smoke POSTed root-choice selected=0, first-child-choice selected=1, second-child-choice selected=0 from both connection types; foreign-session choices were not POSTed.
    • Full all-target test run: 357 passed, 7 failed, 0 ignored. The exact same seven TUI snapshots fail on clean base 1abc6fcff1f186124f924b56aa92c3a3684c90c5 (355 passed, 7 failed). No baselines or tolerances were changed.
    • Doctests: 45 passed, 1 ignored. Rust formatting, workspace Clippy with warnings denied, and all-target compilation passed. Independent read-only review found no blocking issues.

    I am maintaining this proposed fix. The PR remains Draft, not ready or merged: full checks are not green, remote CI currently lists no checks, and maintainer review remains outstanding. The repository script skipped docs/UI Prettier because node_modules are absent; optional browser e2e and THIRD-PARTY verification were not reached after the test gate failed. No live model account was used. No merge, Issue closure, or deployment has been performed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions