Add Windows notification handles#283
Open
Peter7896 wants to merge 1 commit into
Open
Conversation
Author
|
Added a Windows recording for the action callback path: The recording shows:
Local validation already run:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft for #186, Windows side only.
This keeps the existing Windows
show()behavior intact and adds an opt-inshow_handle()path for callbacks. The first pass stays on the current Windows backend because it already exposes activation and dismissal handlers, so this avoids a backend swap while still proving the handle surface.What changed:
NotificationHandlewithwait_for_action,wait_for_action_response, andon_closedefaultfor body activationCloseReasonValidation run on Windows:
cargo checkcargo check --target x86_64-pc-windows-msvc --examplescargo test --target x86_64-pc-windows-msvc --no-runcargo test --target x86_64-pc-windows-msvc wait_for_action -- --nocaptureThis is intentionally still a draft. I still need to attach the requested clean recording before marking it ready for review. My current Windows shell delivered the handle event, but did not render a clean banner capture, so I am not treating this as ready yet.
Refs #186