Skip to content

fix(snapshot): skip notFound and onError handlers of Hono v5 - #164

Merged
yusukebe merged 1 commit into
nextfrom
fix/snapshot-fallback-handlers
Oct 11, 2026
Merged

yusukebe merged 1 commit into
nextfrom
fix/snapshot-fallback-handlers

Conversation

@yusukebe

@yusukebe yusukebe commented Oct 10, 2026 •

Copy link
Copy Markdown
Member

On Hono v5, inspectRoutes lists notFound and onError handlers with methods like @NOT_FOUND and @ERROR. snapshot printed them as lines, so piping its output into hono batch failed with "'@NOT_FOUND' is not a valid HTTP method". Found on a v5 app with app.notFound(). Now snapshot skips them; the probe line still records the not-found response.

The author should do the following, if applicable

  • Add tests
  • Run tests
  • pnpm run format:fix && pnpm run lint:fix to format the code
  • Add TSDoc/JSDoc to document the code

@yusukebe
yusukebe merged commit 00ecfce into next Oct 11, 2026
4 checks passed
@yusukebe
yusukebe deleted the fix/snapshot-fallback-handlers branch October 11, 2026 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant