Skip to content

build: bump sbd crates to 0.4.0 - #203

Merged
mattyg merged 1 commit into
mainfrom
build/bump-sbd-server
Nov 14, 2025
Merged

mattyg merged 1 commit into
mainfrom
build/bump-sbd-server

Conversation

@mattyg

@mattyg mattyg commented Nov 14, 2025 •

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • Chores
    • Updated internal dependencies to latest versions.

@cocogitto-bot

cocogitto-bot Bot commented Nov 14, 2025

Copy link
Copy Markdown

✔️ d0d2ea9 - Conventional commits check succeeded.

@coderabbitai

coderabbitai Bot commented Nov 14, 2025 •

Copy link
Copy Markdown

Walkthrough

Updated workspace dependencies in Cargo.toml, upgrading sbd-e2e-crypto-client and sbd-server from version 0.3.4 to 0.4.0. These are the only modifications in the pull request.

Changes

Cohort / File(s) Change Summary
Workspace Dependencies
Cargo.toml
Bumped sbd-e2e-crypto-client and sbd-server versions from 0.3.4 to 0.4.0

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • Simple version bump updates with no functional code changes or logic modifications required

Possibly related PRs

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely summarizes the main change: bumping SBD crates to version 0.4.0, which matches the actual changes in Cargo.toml.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch build/bump-sbd-server

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6b18a33 and d0d2ea9.

⛔ Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (1)
  • Cargo.toml (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (7)
  • GitHub Check: test (x86_64, 33, 26.0.10792818, datachannel)
  • GitHub Check: test (x86_64, 33, 26.0.10792818, go-pion)
  • GitHub Check: test (x86_64, 29, 26.0.10792818, go-pion)
  • GitHub Check: test (x86_64, 29, 26.0.10792818, datachannel)
  • GitHub Check: Test (macos-latest)
  • GitHub Check: Test (windows-latest)
  • GitHub Check: Test (ubuntu-latest)
🔇 Additional comments (1)
Cargo.toml (1)

38-39: I found a critical discrepancy. Let me investigate further before finalizing the review:

Let me check the crates.io API metadata more thoroughly:

Based on my verification, I've found critical discrepancies that require your attention:

Critical inconsistency detected: Version metadata mismatch

The versions 0.4.0 for both crates exist on crates.io (created today, 2025-11-14) but are not documented anywhere publicly:

  • docs.rs shows sbd-e2e-crypto-client latest documented version is 0.0.2-alpha
  • docs.rs shows sbd-server 0.3.0 as available
  • Your Cargo.toml claims the previous versions are 0.3.4, but this doesn't align with the alpha/pre-release pattern shown in public documentation
  • Both 0.4.0 versions were just published today—no release notes, changelogs, or documentation are available

This suggests one of the following:

  1. These versions were recently extracted from a private registry and hastily published
  2. The version bump is based on incorrect assumptions about what 0.3.4 actually is
  3. There's a mismatch between your internal crate versions and what's publicly available on crates.io

Before merging, you must:

  1. Confirm these 0.4.0 versions are intentional and correct
  2. Verify the actual source repository and release history for these crates
  3. Check the actual breaking changes or API modifications between what you're using and 0.4.0
  4. Ensure all usages of these crates in your workspace have been updated for compatibility

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@mattyg
mattyg requested a review from a team November 14, 2025 20:59
@mattyg
mattyg merged commit d9402ff into main Nov 14, 2025
10 of 14 checks passed
@mattyg
mattyg deleted the build/bump-sbd-server branch November 14, 2025 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants