DBX-5320 Optional ref#937
Open
huydo862003 wants to merge 80 commits into
Open
Conversation
Benchmark Resultdbml-parse
|
Coverage ReportCommit: 4a6baf7 Overall Coverage
Package Coverage
|
| File | Lines | Statements | Functions | Branches |
|---|---|---|---|---|
src/connectors/bigquery/index.ts |
0.00% | 0.00% | 0.00% | 0.00% |
src/utils/credential-loader.ts |
0.00% | 0.00% | 0.00% | 0.00% |
src/utils/helpers.ts |
0.00% | 0.00% | 0.00% | 0.00% |
src/connectors/snowflake/index.ts |
10.56% | 10.31% | 0.00% | 0.00% |
src/utils/parseSchema.ts |
46.15% | 42.85% | 28.57% | 27.27% |
src/connectors/connector.ts |
66.66% | 66.66% | 100.00% | 57.14% |
src/connectors/oracle/tables.ts |
71.25% | 67.39% | 100.00% | 56.96% |
src/connectors/oracle/index.ts |
80.00% | 80.76% | 100.00% | 25.00% |
src/connectors/oracle/utils.ts |
85.71% | 85.71% | 100.00% | 71.42% |
dbml-parse
83 file(s) below 80% coverage
| File | Lines | Statements | Functions | Branches |
|---|---|---|---|---|
src/compiler/queries/container/scope.ts |
0.00% | 0.00% | 0.00% | 0.00% |
src/services/code_actions/provider.ts |
0.00% | 0.00% | 0.00% | 0.00% |
src/services/diagnostics/provider.ts |
0.00% | 0.00% | 0.00% | 0.00% |
src/compiler/queries/pipeline/interpret.ts |
10.52% | 12.19% | 66.66% | 41.66% |
src/services/suggestions/crossFile.ts |
19.35% | 19.44% | 33.33% | 10.00% |
src/core/local_modules/enum/index.ts |
48.00% | 46.29% | 57.14% | 52.63% |
src/core/global_modules/project/interpret.ts |
52.50% | 46.66% | 83.33% | 23.07% |
src/compiler/queries/legacy/parse.ts |
53.84% | 46.66% | 50.00% | 25.00% |
src/compiler/projectLayout/layout.ts |
54.16% | 53.84% | 75.00% | 52.63% |
src/core/local_modules/ref/index.ts |
62.50% | 61.76% | 100.00% | 57.14% |
src/core/types/report.ts |
62.96% | 56.66% | 76.92% | 57.14% |
src/core/global_modules/records/utils/data/values.ts |
63.30% | 55.71% | 72.72% | 49.28% |
src/core/types/symbol/symbols.ts |
64.41% | 56.50% | 60.80% | 48.48% |
src/core/local_modules/tableGroup/validate.ts |
64.55% | 64.44% | 71.42% | 58.00% |
src/compiler/queries/legacy/token.ts |
66.66% | 66.66% | 66.66% | 100.00% |
src/core/global_modules/enum/bind.ts |
66.66% | 68.75% | 83.33% | 50.00% |
src/core/local_modules/program/index.ts |
66.66% | 69.23% | 75.00% | 62.50% |
src/core/global_modules/note/bind.ts |
69.23% | 71.42% | 83.33% | 50.00% |
src/core/local_modules/checks/index.ts |
69.23% | 75.00% | 100.00% | 64.28% |
src/core/local_modules/project/index.ts |
69.23% | 69.23% | 100.00% | 63.63% |
src/core/local_modules/custom/index.ts |
70.58% | 71.42% | 80.00% | 68.75% |
src/compiler/queries/utils.ts |
73.10% | 73.38% | 90.90% | 51.11% |
src/core/local_modules/tablePartial/validate.ts |
73.12% | 71.83% | 79.22% | 57.67% |
src/core/global_modules/project/bind.ts |
73.33% | 75.00% | 100.00% | 50.00% |
src/core/local_modules/indexes/index.ts |
73.68% | 69.35% | 63.63% | 64.28% |
src/core/local_modules/use/index.ts |
73.91% | 75.00% | 75.00% | 81.25% |
src/core/local_modules/indexes/validate.ts |
74.28% | 74.66% | 90.90% | 56.00% |
src/core/local_modules/note/index.ts |
75.00% | 75.86% | 75.00% | 72.72% |
src/services/suggestions/utils/index.ts |
75.00% | 75.00% | 100.00% | 60.71% |
src/core/local_modules/records/index.ts |
75.60% | 76.19% | 100.00% | 68.08% |
src/core/global_modules/utils.ts |
75.75% | 72.22% | 57.14% | 53.84% |
src/core/local_modules/project/validate.ts |
75.86% | 75.86% | 100.00% | 56.25% |
src/core/global_modules/indexes/bind.ts |
76.31% | 74.35% | 90.90% | 68.96% |
src/core/global_modules/records/utils/data/sqlTypes.ts |
76.59% | 80.64% | 82.35% | 72.22% |
src/core/global_modules/tablePartial/interpret.ts |
77.65% | 70.37% | 78.94% | 53.84% |
src/core/types/relation.ts |
78.12% | 73.56% | 85.71% | 73.55% |
src/core/types/filepath.ts |
79.48% | 78.57% | 77.77% | 70.37% |
src/core/global_modules/program/utils.ts |
80.00% | 80.00% | 100.00% | 70.00% |
src/core/global_modules/tableGroup/bind.ts |
80.00% | 80.00% | 100.00% | 57.14% |
src/core/local_modules/note/validate.ts |
80.00% | 78.18% | 83.33% | 73.68% |
src/core/local_modules/records/validate.ts |
80.28% | 80.55% | 93.75% | 72.30% |
src/core/global_modules/ref/bind.ts |
80.64% | 80.64% | 90.00% | 70.00% |
src/core/global_modules/indexes/interpret.ts |
81.39% | 72.00% | 100.00% | 56.66% |
src/core/local_modules/tablePartial/index.ts |
81.48% | 81.48% | 100.00% | 77.27% |
src/core/local_modules/diagramView/validate.ts |
81.57% | 78.04% | 84.21% | 72.72% |
src/core/local_modules/checks/validate.ts |
81.63% | 82.69% | 93.75% | 70.00% |
src/core/global_modules/records/bind.ts |
82.92% | 83.72% | 93.75% | 67.30% |
src/compiler/queries/container/token.ts |
83.33% | 85.71% | 100.00% | 75.00% |
__tests__/utils/compiler.ts |
84.28% | 82.25% | 100.00% | 58.97% |
src/core/parser/parser.ts |
84.52% | 84.75% | 100.00% | 76.09% |
src/core/utils/setting.ts |
84.84% | 80.95% | 85.71% | 68.75% |
src/core/local_modules/table/validate.ts |
84.92% | 85.47% | 90.24% | 73.40% |
src/core/local_modules/enum/validate.ts |
85.48% | 81.81% | 81.25% | 76.31% |
__tests__/utils/mocks.ts |
85.71% | 86.20% | 75.00% | 100.00% |
src/core/global_modules/use/index.ts |
86.59% | 83.20% | 100.00% | 78.22% |
src/services/suggestions/utils/useMerger.ts |
86.95% | 81.13% | 100.00% | 46.34% |
src/core/global_modules/tablePartial/bind.ts |
87.03% | 87.27% | 100.00% | 71.42% |
src/core/global_modules/tableGroup/interpret.ts |
88.37% | 88.37% | 100.00% | 77.27% |
src/services/suggestions/provider.ts |
88.43% | 84.41% | 98.41% | 76.75% |
src/services/suggestions/recordRowSnippet.ts |
88.46% | 87.09% | 100.00% | 73.80% |
src/core/types/symbol/metadata.ts |
88.72% | 75.60% | 90.00% | 59.66% |
src/compiler/queries/nodeAtPosition.ts |
88.88% | 90.00% | 100.00% | 75.00% |
src/core/global_modules/diagramView/index.ts |
89.16% | 86.23% | 83.33% | 78.18% |
src/compiler/index.ts |
90.00% | 90.07% | 70.00% | 76.92% |
src/core/global_modules/table/interpret.ts |
90.62% | 84.61% | 95.45% | 67.02% |
src/core/global_modules/records/index.ts |
90.90% | 87.15% | 100.00% | 79.16% |
src/core/global_modules/records/utils/constraints/pk.ts |
91.66% | 88.88% | 93.75% | 63.15% |
src/core/global_modules/schema/index.ts |
92.26% | 82.46% | 91.66% | 70.07% |
src/core/utils/interpret.ts |
93.33% | 90.00% | 100.00% | 73.23% |
src/core/global_modules/diagramView/interpret.ts |
94.59% | 90.40% | 92.85% | 75.75% |
src/services/suggestions/use.ts |
94.68% | 87.61% | 100.00% | 77.45% |
src/core/global_modules/note/interpret.ts |
95.65% | 95.65% | 100.00% | 75.00% |
src/core/global_modules/ref/interpret.ts |
95.83% | 94.11% | 100.00% | 78.84% |
src/core/global_modules/records/interpret.ts |
95.97% | 92.59% | 100.00% | 79.54% |
__tests__/examples/interpreter/multifile/utils.ts |
96.00% | 89.65% | 100.00% | 62.50% |
src/compiler/queries/canonicalName.ts |
96.96% | 92.10% | 100.00% | 76.66% |
src/core/global_modules/program/interpret.ts |
97.22% | 91.82% | 100.00% | 70.31% |
src/core/types/errors.ts |
98.59% | 98.59% | 75.00% | 100.00% |
src/compiler/queries/transform/renameTable.ts |
99.05% | 90.47% | 100.00% | 78.82% |
src/core/global_modules/checks/interpret.ts |
100.00% | 88.88% | 100.00% | 60.00% |
src/core/global_modules/program/index.ts |
100.00% | 85.71% | 100.00% | 75.00% |
src/core/global_modules/records/utils/constraints/unique.ts |
100.00% | 94.28% | 100.00% | 58.33% |
src/services/definition/provider.ts |
100.00% | 95.23% | 100.00% | 71.42% |
huydo862003
force-pushed
the
optional-ref-2
branch
from
July 1, 2026 04:33
f70301d to
c5a7016
Compare
huydo862003
force-pushed
the
optional-ref-2
branch
2 times, most recently
from
July 1, 2026 04:50
c2c5723 to
162bcf5
Compare
huydo862003
force-pushed
the
optional-ref-2
branch
from
July 1, 2026 04:56
162bcf5 to
f74727f
Compare
huydo862003
force-pushed
the
optional-ref-2
branch
from
July 8, 2026 04:55
295a20f to
65a8767
Compare
huydo862003
force-pushed
the
optional-ref-2
branch
from
July 8, 2026 05:16
65a8767 to
e929a70
Compare
huydo862003
force-pushed
the
optional-ref-2
branch
from
July 13, 2026 09:25
b0e2612 to
26d8be0
Compare
huydo862003
force-pushed
the
optional-ref-2
branch
from
July 13, 2026 09:28
26d8be0 to
b0e6f71
Compare
xuantho573
reviewed
Jul 16, 2026
| if (s instanceof CompileError) return 6; | ||
| if (s instanceof CompileInfo) return 5; | ||
| if (s instanceof CompileWarning) return 6; | ||
| if (s instanceof CompileError) return 7; |
Member
There was a problem hiding this comment.
Should the values below be increased?
Contributor
Author
There was a problem hiding this comment.
it's internal to the tests for consistent ordering only, wherever is fine, as long as the partial ordering among the old objects do not change :*
| const c = this.cardinalities(compiler); | ||
| return c ? parseCardinality(c[1]) : undefined; | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
These 2 seem to not be used anywhere 🤔
Contributor
Author
There was a problem hiding this comment.
yeah but just kept it though, it can be useful :pepe-cuoi-guong:
Comment on lines
+312
to
+319
| leftCardinality (compiler: Compiler): { min: number; max: number | '*' } | undefined { | ||
| const c = this.cardinalities(compiler); | ||
| return c ? parseCardinality(c[0]) : undefined; | ||
| } | ||
|
|
||
| rightCardinality (compiler: Compiler): { min: number; max: number | '*' } | undefined { | ||
| const c = this.cardinalities(compiler); | ||
| return c ? parseCardinality(c[1]) : undefined; |
Member
There was a problem hiding this comment.
These 2 seem to not be used anywhere 🤔
Contributor
Author
There was a problem hiding this comment.
yeah but just kept it though, it can be useful :pepe-cuoi-guong:
Comment on lines
+32
to
+42
| export function updateSettingEdit ( | ||
| declaration: SyntaxNode, | ||
| settingName: string, | ||
| newValue: string, | ||
| source: string, | ||
| ): TextEdit | undefined { | ||
| const found = findSetting(source, declaration, settingName); | ||
| if (!found) return undefined; | ||
|
|
||
| return { start: found.settingNode.start, end: found.settingNode.end, newText: newValue }; | ||
| } |
Member
There was a problem hiding this comment.
This seems to not be used anywhere 🤔
Contributor
Author
There was a problem hiding this comment.
it's used in #933 nhó, we're about to update fragile regexes in dbdiagram-frontend to these.
Comment on lines
+111
to
+112
| "onDelete": null, | ||
| "onUpdate": null |
Member
There was a problem hiding this comment.
Do we have a way to ensure either:
- Empty/null/undefined values don't appear on the output json
- They do appear
so the test output won't necessarily change in future works?
The output at packages/dbml-core/__tests__/examples/parser/mssql-parse/output/table_constraints_indexes.out.json at line 316 does not have onUpdate but I assume it'll be onUpdate: null.
Contributor
Author
There was a problem hiding this comment.
may need to either normalize the output before outputting like in @dbml/parse :3 but maybe another pr would do
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BREAKING CHANGE
All "many" endpoints are now "some" (min=1):
>: many-to-one -> some-to-one ([1..*]-[1..1])<: one-to-many -> one-to-some ([1..1]-[1..*])<>: many-to-many -> some-to-some ([1..*]-[1..*])-: one-to-one (unchanged)SQL importers/db connectors will default to optional ref cardinalities & the model_structure layer in @dbml/core will adjust the cardinalities to required if it makes sense
New features
?modifier for optional (min=0) endpoints:?>: many-to-one ([0..*]-[1..1])?-?: maybe-to-maybe ([0..1]-[0..1])Changes
RefEndpoint.relationextended from'1' | '*'to'1','*','0..1','0..*', etc.?>?,?<>?etc. as single OP tokensIssue
(issue link here)
Lasting Changes (Technical)
(please list down: code changes/things that have wide-effect; new libraries/functions added that can be used by others; examples below)
class EmailValidatorto validate email address' validity)Tenant#is_trial?check)Checklist
Please check directly on the box once each of these are done