Skip to content

[1/2] Defer tactic argument rendering until trace dump #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Wilson1211 wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

[1/2] Defer tactic argument rendering until trace dump #1

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c388c96
Defer tactic argument rendering until trace dump
Wilson1211 Sep 20, 2026
9f33164
Explain lazy tactic argument retention
Wilson1211 Sep 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions exportTrace.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ module ExportTrace = struct
output: thm
}

(* Separate record_args to lazily evaluate this (otherwise it takes too long) *)
(* Keep record_args separate so tactic records can render them lazily. *)
type record_args = {
names: string list;
types: string list;
Expand Down Expand Up @@ -65,7 +65,7 @@ module ExportTrace = struct
}

let all_tac_records_interesting
(tr: (tac_record * record_args * tac_record_interestingness) list): bool =
(tr: (tac_record * record_args Lazy.t * tac_record_interestingness) list): bool =
let interesting_concl_strlen = 100 in
List.for_all (fun (_,_,i) -> i.input_concl_str_len < interesting_concl_strlen)
tr
Expand Down Expand Up @@ -105,8 +105,10 @@ module ExportTrace = struct

let tac_logs
:(string,
(tac_record * record_args * tac_record_interestingness) list)
(tac_record * record_args Lazy.t * tac_record_interestingness) list)
Hashtbl.t =
(* Tactic arguments stay lazy while records compete for retention.
Conversion records remain eager below. *)
Hashtbl.create 128
let conv_logs
:(string,
Expand All @@ -129,7 +131,8 @@ let exptrace_add_tac (tactic_name:string)
(* Lazily calculate interestingness of this tac_record 're'. *)
let mk_i () = ExportTrace.mk_tac_record_interestingness re in

let mk_full_rec() = (re, re_arg_gen(), mk_i()) in
(* Do not call re_arg_gen here: the retention logic may discard this record. *)
let mk_full_rec() = (re, lazy (re_arg_gen()), mk_i()) in

match Hashtbl.find_opt logs tactic_name with
| None ->
Expand Down Expand Up @@ -196,7 +199,9 @@ let exptrace_dump (dir_path:string): unit =
let oc = open_out path in

Printf.fprintf oc "[\n";
List.iteri (fun i ((r:ExportTrace.tac_record),(r_args:ExportTrace.record_args),_) ->
List.iteri (fun i ((r:ExportTrace.tac_record),r_args_lazy,_) ->
(* Render arguments only after this record has survived retention. *)
let r_args:ExportTrace.record_args = Lazy.force r_args_lazy in
Printf.fprintf oc " {\n";
Printf.fprintf oc " \"tactic\":\"%s\",\n" tac;
Printf.fprintf oc " \"definition_line_number\": {\n";
Expand Down
Loading