Skip to content

refactoring changes, added new Pin class and clockPinManager Class - #1144

Open
shahrajsingh wants to merge 5 commits into
hneemann:masterfrom
shahrajsingh:refactoring_set_2
Open

refactoring changes, added new Pin class and clockPinManager Class#1144
shahrajsingh wants to merge 5 commits into
hneemann:masterfrom
shahrajsingh:refactoring_set_2

Conversation

@shahrajsingh

Copy link
Copy Markdown

Updated the PinMap class:
Removed the inner Pin class.
Removed the clockPin variable and associated getter and setter methods.
Made the PinMap class inherit from the ClockPinManager class.

@codecov-commenter

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 86.84211% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 56.6%. Comparing base (aa9c142) to head (a7689e7).
⚠️ Report is 70 commits behind head on master.

Files with missing lines Patch % Lines
.../de/neemann/digital/builder/ATF150x/ATFDevice.java 0.0% 3 Missing ⚠️
...va/de/neemann/digital/builder/ClockPinManager.java 80.0% 0 Missing and 1 partial ⚠️
...c/main/java/de/neemann/digital/builder/PinMap.java 83.3% 0 Missing and 1 partial ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff            @@
##             master   #1144   +/-   ##
========================================
  Coverage      56.5%   56.6%           
- Complexity     6571    6576    +5     
========================================
  Files           679     681    +2     
  Lines         35494   35512   +18     
  Branches       4792    4795    +3     
========================================
+ Hits          20082   20109   +27     
+ Misses        14202   14196    -6     
+ Partials       1210    1207    -3     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants