Skip to content

Thread a database handle through Init - #181

Open
Calm0 wants to merge 2 commits into
mainfrom
nabil/feat/thread-db-through-init
Open

Calm0 wants to merge 2 commits into
mainfrom
nabil/feat/thread-db-through-init

Conversation

@Calm0

@Calm0 Calm0 commented Sep 21, 2026

Copy link
Copy Markdown
Member

Init now takes a *sql.DB and passes it to the plugin entrypoint, so gameplay systems can reach the database directly instead of only through the runtime module. The plugin type assertion is updated to match.

@Calm0
Calm0 requested review from a team and zyro and a lite review from Copilot September 21, 2026 11:41

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

Update the README usage examples for the new required Init argument.

Get a fresh assessment by requesting another Copilot review.

Review effort: Lite
Findings: 1 Low severity

Open (1)
What changed in this PR

Updates Init to accept and forward a database handle to the plugin entrypoint.

Changes:

  • Adds *sql.DB to the Init signature.
  • Updates the plugin type assertion and invocation.
  • Documents the API change in the changelog.
File Summary
CHANGELOG.md Documents the updated Init API.
base.go Threads the database handle through Init.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread base.go
Copilot AI review requested due to automatic review settings September 21, 2026 12:06

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

Existing binaries may fail at runtime, and the documented initialization example remains incompatible.

Get a fresh assessment by requesting another Copilot review.

Review effort: Lite
Findings: 1 High severity · 1 Low severity

Open (2)

Comment thread base.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants