refactor(x86_64/paging): extract UEFI check out of make_p4_writable()

[mkroening]

This makes gating the function easier.

Extracted from #2546.

[github-actions]

Benchmark Results

Details

Benchmark	Current: b8a3714	Previous: 2e23902	Performance Ratio
startup_benchmark Build Time	80.99 s	80.34 s	1.01 ❗
startup_benchmark File Size	0.79 MB	0.80 MB	1.00 ❗
Startup Time - 1 core	0.77 s (±0.02 s)	0.75 s (±0.02 s)	1.03
Startup Time - 2 cores	0.76 s (±0.02 s)	0.74 s (±0.02 s)	1.03
Startup Time - 4 cores	0.76 s (±0.03 s)	0.74 s (±0.02 s)	1.02
multithreaded_benchmark Build Time	85.24 s	82.11 s	1.04 ❗
multithreaded_benchmark File Size	0.90 MB	0.86 MB	1.05 ❗
Multithreaded Pi Efficiency - 2 Threads	87.07 % (±7.71 %)	85.89 % (±6.61 %)	1.01
Multithreaded Pi Efficiency - 4 Threads	43.44 % (±2.51 %)	43.43 % (±2.56 %)	1.00
Multithreaded Pi Efficiency - 8 Threads	25.30 % (±1.32 %)	25.76 % (±1.53 %)	0.98
micro_benchmarks Build Time	80.09 s	80.40 s	1.00 ❗
micro_benchmarks File Size	0.90 MB	0.86 MB	1.05 ❗
Scheduling time - 1 thread	66.79 ticks (±3.74 ticks)	62.65 ticks (±4.06 ticks)	1.07
Scheduling time - 2 threads	36.92 ticks (±4.60 ticks)	34.08 ticks (±4.10 ticks)	1.08
Micro - Time for syscall (getpid)	4.08 ticks (±0.61 ticks)	3.45 ticks (±0.58 ticks)	1.18
Memcpy speed - (built_in) block size 4096	82062.66 MByte/s (±56829.76 MByte/s)	82448.38 MByte/s (±56997.13 MByte/s)	1.00
Memcpy speed - (built_in) block size 1048576	30526.72 MByte/s (±24653.60 MByte/s)	30585.98 MByte/s (±24707.84 MByte/s)	1.00
Memcpy speed - (built_in) block size 16777216	24719.81 MByte/s (±20464.45 MByte/s)	26340.06 MByte/s (±21720.96 MByte/s)	0.94
Memset speed - (built_in) block size 4096	82151.04 MByte/s (±56887.71 MByte/s)	82292.76 MByte/s (±56891.50 MByte/s)	1.00
Memset speed - (built_in) block size 1048576	31305.66 MByte/s (±25118.94 MByte/s)	31323.85 MByte/s (±25145.86 MByte/s)	1.00
Memset speed - (built_in) block size 16777216	25278.16 MByte/s (±20767.82 MByte/s)	27104.68 MByte/s (±22209.94 MByte/s)	0.93
Memcpy speed - (rust) block size 4096	74570.28 MByte/s (±51890.95 MByte/s)	74097.96 MByte/s (±51811.44 MByte/s)	1.01
Memcpy speed - (rust) block size 1048576	30220.43 MByte/s (±24490.13 MByte/s)	30361.60 MByte/s (±24602.37 MByte/s)	1.00
Memcpy speed - (rust) block size 16777216	25406.37 MByte/s (±20947.63 MByte/s)	27625.34 MByte/s (±22806.88 MByte/s)	0.92
Memset speed - (rust) block size 4096	74641.71 MByte/s (±51937.21 MByte/s)	74373.47 MByte/s (±51976.48 MByte/s)	1.00
Memset speed - (rust) block size 1048576	30959.61 MByte/s (±24920.73 MByte/s)	31110.89 MByte/s (±25033.24 MByte/s)	1.00
Memset speed - (rust) block size 16777216	25864.57 MByte/s (±21164.49 MByte/s)	28386.93 MByte/s (±23265.03 MByte/s)	0.91
alloc_benchmarks Build Time	80.12 s	74.76 s	1.07 ❗
alloc_benchmarks File Size	0.87 MB	0.87 MB	1.00 ❗
Allocations - Allocation success	91.31 %	91.31 %	1
Allocations - Deallocation success	100.00 %	100.00 %	1
Allocations - Pre-fail Allocations	61.44 %	61.44 %	1
Allocations - Average Allocation time	4391.27 Ticks (±169.63 Ticks)	5860.58 Ticks (±98.43 Ticks)	0.75 ❗
Allocations - Average Allocation time (no fail)	5169.06 Ticks (±157.64 Ticks)	6554.81 Ticks (±92.86 Ticks)	0.79 ❗
Allocations - Average Deallocation time	1039.93 Ticks (±172.06 Ticks)	1805.01 Ticks (±250.35 Ticks)	0.58 ❗
mutex_benchmark Build Time	78.13 s	79.82 s	0.98 ❗
mutex_benchmark File Size	0.90 MB	0.86 MB	1.05 ❗
Mutex Stress Test Average Time per Iteration - 1 Threads	12.10 ns (±0.36 ns)	12.10 ns (±0.41 ns)	1.00
Mutex Stress Test Average Time per Iteration - 2 Threads	40.60 ns (±2.50 ns)	40.26 ns (±1.68 ns)	1.01

This comment was automatically generated by workflow using github-action-benchmark.