Conversation
Discover Kiro session ids from stock lock files while the agent is running, persist them via the existing agent_session path, and relaunch with `kiro-cli chat [--v3] --resume-id <id>` on restore. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Important Review skippedAuto reviews are limited based on label configuration. 🏷️ Required labels (at least one) (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Hi @sahilk335, thanks for your interest in contributing. Herdr does not accept unsolicited implementation pull requests from contributors who are not listed in The pull request author is not an approved contributor. If you encountered a reproducible bug, report the observed behavior through the bug issue template. A report does not reserve the work or authorize a pull request; accepted fixes are normally implemented by Herdr’s maintainer-controlled agents. Feature requests, behavior changes, and other proposals belong in GitHub Discussions. Do not open an issue merely to justify an implementation that was already written. If a maintainer explicitly wants this implementation, they can reopen the pull request. Reopening by anyone else will be closed again automatically. See https://github.com/herdrdev/herdr/blob/master/CONTRIBUTING.md for the contribution policy. |
Summary
Fixes Kiro panes coming back as empty shells after a Herdr server restart when
resume_agents_on_restore = true.~/.kiro/sessionsand matching the lock owner pid against the pane's process treeAgentSessionReported/agent_sessionpersistence path (source: herdr:kiro)kiro-cli chat [--v3] --resume-id <SESSION_ID>(V3 ids get--v3)parent_process_idon macOS and Linux; stubs on Windows/fallbackFollow-up to #749 / #4358: Herdr 0.9.1 detects Kiro and persists
managed_agent_kind, but never records the conversation session id, so restore has nothing to resume.Test plan
cargo test --bin herdr kiro_session— 4/4 passcargo test --bin herdr agent_resume— includes new Kiro planner and report validation caseskill -9on the Herdr server and restore into the same conversation/procparent lookup (straightforward, not run here)Made with Cursor