ETT-1134, 1136: a11y fixes for feedback form and results pagination#150
Merged
Conversation
moseshll
approved these changes
Jun 11, 2026
moseshll
left a comment
Contributor
There was a problem hiding this comment.
I've used the features on dev-3 and looked at the markup. All appears to be well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These two tickets were small enough that I combined them in one PR.
ETT-1134: Invalid
typeattribute in<input>The feedback forms had an invalid
type="name"(type of name doesn't exist), so I deleted it from all three versions of the form.ETT-1136: Links use
disabledattributeWe've already fixed this issue in pt, so I did the same thing here. The issue is that when there is no "previous" or "next" page of results, the link (that looks like a button) sets a
disabledstate, but<a>elements can't have adisabledstate. I added a conditional that used the same variables from the component and render a disabled button (no link) instead of the link when necessary.Gayathri and I went back and forth on the best method to achieve this, and in the end we relied on this article from CSS Tricks (knowing that the
disabledattribute can be problematic but is the best use case for pagination) and copied the example from theWCAG's pagination documentation.To test
Staged on dev-3: https://dev-3.babel.hathitrust.org/cgi/ls?q1=elephant;field1=ocr;a=srchls;ft=ft;lmt=ft
You can take a look at the feedback form markup if you want, but it didn't change the UI in any way.
The results pagination also doesn't really look different, but I guess you could go over there and try tabbing around and make sure it's not broken.
The storybook tests pass and I tested this on dev-3.