Skip to content

ETT-1134, 1136: a11y fixes for feedback form and results pagination#150

Merged
carylwyatt merged 4 commits into
mainfrom
a11y-fixes
Jun 11, 2026
Merged

ETT-1134, 1136: a11y fixes for feedback form and results pagination#150
carylwyatt merged 4 commits into
mainfrom
a11y-fixes

Conversation

@carylwyatt

Copy link
Copy Markdown
Member

These two tickets were small enough that I combined them in one PR.

ETT-1134: Invalid type attribute in <input>

The feedback forms had an invalid type="name" (type of name doesn't exist), so I deleted it from all three versions of the form.

ETT-1136: Links use disabled attribute

We've already fixed this issue in pt, so I did the same thing here. The issue is that when there is no "previous" or "next" page of results, the link (that looks like a button) sets a disabled state, but <a> elements can't have a disabled state. I added a conditional that used the same variables from the component and render a disabled button (no link) instead of the link when necessary.

Gayathri and I went back and forth on the best method to achieve this, and in the end we relied on this article from CSS Tricks (knowing that the disabled attribute can be problematic but is the best use case for pagination) and copied the example from theWCAG's pagination documentation.

To test

Staged on dev-3: https://dev-3.babel.hathitrust.org/cgi/ls?q1=elephant;field1=ocr;a=srchls;ft=ft;lmt=ft

You can take a look at the feedback form markup if you want, but it didn't change the UI in any way.

The results pagination also doesn't really look different, but I guess you could go over there and try tabbing around and make sure it's not broken.

The storybook tests pass and I tested this on dev-3.

@carylwyatt carylwyatt requested a review from moseshll June 11, 2026 17:43

@moseshll moseshll left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've used the features on dev-3 and looked at the markup. All appears to be well.

@carylwyatt carylwyatt merged commit 9764ab6 into main Jun 11, 2026
6 checks passed
@carylwyatt carylwyatt deleted the a11y-fixes branch June 11, 2026 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants