ETT-1410 advanced search causing error 505#134
Merged
Conversation
- The catalog is basically broken for all `ssduser`s because `ping` sets the HTStatus cookie `u` field to `true` but does not provide any activated role names in the `r` field. It's just the way `ping` works. - `RecordUtils->ht_link_data_from_json` would blindly call `array_keys` on a `NULL` value in that case. - Now check `$htstatus->r` and the count of its keys before trying extract the role name from it. - Add a test with simulated `ssduser`.
aelkiss
approved these changes
Apr 8, 2026
aelkiss
left a comment
aelkiss
left a comment
Member
There was a problem hiding this comment.
Works for me on dev-2 with role set to ssduser. Let's go ahead and merge & deploy ASAP.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ssdusers becausepingsets the HTStatus cookieufield totruebut does not provide any activated role names in therfield. It's just the waypingworks.RecordUtils->ht_link_data_from_jsonwould blindly callarray_keyson aNULLvalue in that case.$htstatus->rand the count of its keys before trying extract the role name from it.ssduser.Staged on dev-2