Clean up unused code on Record and Search#133
Conversation
There was a problem hiding this comment.
Happy to see the XSL go bye-bye!
There is an additional issue in production that may be related to this, and probably makes sense to fix here:
I looked in a record page source and saw (this is up in the header)
<link rel="alternate" href="/Record/008694574.rdf" type="application/rdf+xml" >
and unfortunately that link goes to a page that just says Method rdf not recognized.
I think we've looked at this before, but only in passing.
The issue is:
./interface/themes/firebird/layout.tpl:48: <link rel="alternate" href="/Record/{$id|escape:"url"}.rdf" type="application/rdf+xml" >
I think we can just get rid of that line. @carylwyatt would probably agree... question mark?
I have no idea what |
aelkiss
left a comment
There was a problem hiding this comment.
Very happy to see this all go.
| <link rel="alternate" type="application/marc+xml" href="/Record/{$id|escape:"url"}.xml" > | ||
| <link rel="alternate" type="application/x-Research-Info-Systems" href="/Record/{$id|escape:"url"}.ris" > | ||
| <link rel="alternate" type="application/x-endnote-refer" href="/Record/{$id|escape:"url"}.endnote" > | ||
| <link rel="alternate" href="/Record/{$id|escape:"url"}.rdf" type="application/rdf+xml" > |
There was a problem hiding this comment.
Agreed this can go -- I don't think it will have worked at least since 2016 when the rdf function in SearchExport was commented out. The rdf.tpl that was referenced there was removed in 2021.
FY: @moseshll and @carylwyatt, I've removed the |
This PR removes unused scripts. While reviewing the Catalog documentation, Aaron came across this list of unused code.
I've tested these changes locally, and everything is working fine.
e.g.
http://localhost:8080/Record/100685952.marc
http://localhost:8080/Record/100685952/Cite
Once the tests are completed successfully in GitHub, we'll be all set to merge it.