chore(renovate): ignore generated Dockerfiles - #215
Merged
Conversation
The `*/Dockerfile` files are generated from `.ncl` sources by generate_dockerfiles.nu (see .github/workflows/generator.yml). Renovate was editing them directly — e.g. rewriting every `debian:bookworm` to `debian:trixie` (haskell#193) — which is pointless (regenerated on next run) and wrong (the codename is a deliberate choice, not a version pin). Add `**/Dockerfile` to ignorePaths so the dockerfile manager skips generated output. Base-image changes stay a human decision made in the .ncl sources.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
*/Dockerfilefiles are generated from.nclsources bygenerate_dockerfiles.nu(see.github/workflows/generator.yml). Renovate was editing them directly — e.g. rewriting everydebian:bookwormtodebian:trixiein #193 — which is:bookworm/bullseye) is a deliberate per-image choice, not a version pin to bumpAdd
**/DockerfiletoignorePathsso thedockerfilemanager skips generated output. The manager does not scan.ncl, so nothing replaces it; base-image changes stay a human decision made in the.nclsources.Verified:
renovate.jsonparses, and the pattern matches all*/Dockerfilepaths but not the.nclsources.