Skip to content

Add support for linux/s390x and linux/arm64 (Red Hat) - #1152

Merged
benashz merged 16 commits into
mainfrom
VAULT-34419,VAULT-40777/build-for-Z
Nov 21, 2025
Merged

benashz merged 16 commits into
mainfrom
VAULT-34419,VAULT-40777/build-for-Z

Conversation

@benashz

@benashz benashz commented Nov 17, 2025

Copy link
Copy Markdown
Collaborator

Build and publish container images for:

  • linux/s390x

  • linux/arm64

  • Adapt integrations tests to be compatible with the above platforms. Adds a new mini Helm chart for deploying Postgres.

  • Make dependabot run every day to reduce the lag between secvulns - which seem to be on the rise.

  • Drop the obsolete ubi-redhat build step

Helm:

  • Add the ability set the securityContext for the CSI driver.

PCI review checklist

  • I have documented a clear reason for, and description of, the change I am making.

  • If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.

  • If applicable, I've documented the impact of any changes to security controls.

Adds support running VSO on linux/390x.

@benashz
benashz requested a review from a team as a code owner November 17, 2025 16:30
@benashz benashz changed the title Vault 34419,vault 40777/build for z Add support for linux/s390x Nov 17, 2025
@benashz benashz mentioned this pull request Nov 17, 2025
3 tasks
@benashz
benashz force-pushed the VAULT-34419,VAULT-40777/build-for-Z branch 2 times, most recently from b1f8dac to 3a1549e Compare November 18, 2025 21:58
@benashz
benashz force-pushed the VAULT-34419,VAULT-40777/build-for-Z branch from 3a1549e to c37868c Compare November 18, 2025 22:08
@benashz
benashz requested review from digivava and tvoran November 20, 2025 17:24
@benashz benashz changed the title Add support for linux/s390x Add support for linux/s390x and linux/arm64 Nov 20, 2025
@benashz benashz changed the title Add support for linux/s390x and linux/arm64 Add support for linux/s390x and linux/arm64 (Red Hat) Nov 20, 2025
@tvoran

tvoran commented Nov 20, 2025

Copy link
Copy Markdown
Member

Should we add the OLM bundle labels for the architectures here or is that going to be done later?

I think we just need to add a labels block under metadata in the ClusterServiceVersion:

  labels:
    operatorframework.io/os.zos: supported
    operatorframework.io/os.linux: supported
    operatorframework.io/arch.s390x: supported
    operatorframework.io/arch.amd64: supported
    operatorframework.io/arch.arm64: supported

(There are no labels there now since it defaults to just linux/amd64.)

Comment thread .github/workflows/build.yaml
@prb112

prb112 commented Nov 21, 2025

Copy link
Copy Markdown
    operatorframework.io/os.zos: supported

You don't need to do the above. you are only compiling for linux? right

@benashz

benashz commented Nov 21, 2025

Copy link
Copy Markdown
Collaborator Author

You don't need to do the above. you are only compiling for linux? right

@prb112 yes, so basically drop that line?

@prb112

prb112 commented Nov 21, 2025

Copy link
Copy Markdown

You don't need to do the above. you are only compiling for linux? right

@prb112 yes, so basically drop that line?

Right

@benashz

benashz commented Nov 21, 2025

Copy link
Copy Markdown
Collaborator Author

You don't need to do the above. you are only compiling for linux? right

@prb112 yes, so basically drop that line?

Right

Ah, yeah that makes sense; zOS is an entirely different beast altogether.

@benashz

benashz commented Nov 21, 2025

Copy link
Copy Markdown
Collaborator Author

Should we add the OLM bundle labels for the architectures here or is that going to be done later?

I think we just need to add a labels block under metadata in the ClusterServiceVersion:

  labels:
    operatorframework.io/os.zos: supported
    operatorframework.io/os.linux: supported
    operatorframework.io/arch.s390x: supported
    operatorframework.io/arch.amd64: supported
    operatorframework.io/arch.arm64: supported

(There are no labels there now since it defaults to just linux/amd64.)

Thanks @tvoran

Added (minus the zOS bit) in 42aa835 and a4e1256

@benashz
benashz requested a review from tvoran November 21, 2025 16:58
Comment thread .release/vault-secrets-operator-artifacts.hcl Outdated
Co-authored-by: Theron Voran <tvoran@users.noreply.github.com>

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to add a license header to everything in this postgresql chart?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I suppose so - it is our code. I will put up another PR.

copywrite is weird.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like were missing a check for that: #1158 fixes both issues.

@tvoran tvoran left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a question about license headers, but 👍

@benashz
benashz merged commit acbf601 into main Nov 21, 2025
55 checks passed
@benashz
benashz deleted the VAULT-34419,VAULT-40777/build-for-Z branch November 21, 2025 18:15
jaireddjawed added a commit that referenced this pull request Dec 1, 2025
…ate (#1167)

* Bump golang.org/x/crypto from 0.43.0 to 0.45.0 (#1154)

Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.43.0 to 0.45.0.
- [Commits](golang/crypto@v0.43.0...v0.45.0)

---
updated-dependencies:
- dependency-name: golang.org/x/crypto
  dependency-version: 0.45.0
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Add support for linux/s390x and linux/arm64 (Red Hat) (#1152)

* Bump ubi10 to 10.1
* Update the build
* Run dependabot daily for all types
* Fix integration test make target
* Add bats test for CSI driver securityContext
* Rejig the build add arm64 support
* Drop vestigial build-docker-ubi-redhat step
* Add operator framework labels.

Helm:
- Add the ability set the securityContext for the CSI driver.


Co-authored-by: Theron Voran <tvoran@users.noreply.github.com>

---------

Co-authored-by: Theron Voran <tvoran@users.noreply.github.com>

* Include s390x build in release default (#1160)

* Bump the gomod-backward-compatible group with 7 updates (#1157)

Bumps the gomod-backward-compatible group with 7 updates:

| Package | From | To |
| --- | --- | --- |
| [github.com/go-openapi/runtime](https://github.com/go-openapi/runtime) | `0.29.1` | `0.29.2` |
| [github.com/gruntwork-io/terratest](https://github.com/gruntwork-io/terratest) | `0.52.0` | `0.53.0` |
| [google.golang.org/api](https://github.com/googleapis/google-api-go-client) | `0.255.0` | `0.256.0` |
| [k8s.io/api](https://github.com/kubernetes/api) | `0.34.1` | `0.34.2` |
| [k8s.io/apiextensions-apiserver](https://github.com/kubernetes/apiextensions-apiserver) | `0.34.1` | `0.34.2` |
| [k8s.io/apimachinery](https://github.com/kubernetes/apimachinery) | `0.34.1` | `0.34.2` |
| [k8s.io/client-go](https://github.com/kubernetes/client-go) | `0.34.1` | `0.34.2` |


Updates `github.com/go-openapi/runtime` from 0.29.1 to 0.29.2
- [Release notes](https://github.com/go-openapi/runtime/releases)
- [Commits](go-openapi/runtime@v0.29.1...v0.29.2)

Updates `github.com/gruntwork-io/terratest` from 0.52.0 to 0.53.0
- [Release notes](https://github.com/gruntwork-io/terratest/releases)
- [Commits](gruntwork-io/terratest@v0.52.0...v0.53.0)

Updates `google.golang.org/api` from 0.255.0 to 0.256.0
- [Release notes](https://github.com/googleapis/google-api-go-client/releases)
- [Changelog](https://github.com/googleapis/google-api-go-client/blob/main/CHANGES.md)
- [Commits](googleapis/google-api-go-client@v0.255.0...v0.256.0)

Updates `k8s.io/api` from 0.34.1 to 0.34.2
- [Commits](kubernetes/api@v0.34.1...v0.34.2)

Updates `k8s.io/apiextensions-apiserver` from 0.34.1 to 0.34.2
- [Release notes](https://github.com/kubernetes/apiextensions-apiserver/releases)
- [Commits](kubernetes/apiextensions-apiserver@v0.34.1...v0.34.2)

Updates `k8s.io/apimachinery` from 0.34.1 to 0.34.2
- [Commits](kubernetes/apimachinery@v0.34.1...v0.34.2)

Updates `k8s.io/client-go` from 0.34.1 to 0.34.2
- [Changelog](https://github.com/kubernetes/client-go/blob/master/CHANGELOG.md)
- [Commits](kubernetes/client-go@v0.34.1...v0.34.2)

---
updated-dependencies:
- dependency-name: github.com/go-openapi/runtime
  dependency-version: 0.29.2
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: gomod-backward-compatible
- dependency-name: github.com/gruntwork-io/terratest
  dependency-version: 0.53.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: gomod-backward-compatible
- dependency-name: google.golang.org/api
  dependency-version: 0.256.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: gomod-backward-compatible
- dependency-name: k8s.io/api
  dependency-version: 0.34.2
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: gomod-backward-compatible
- dependency-name: k8s.io/apiextensions-apiserver
  dependency-version: 0.34.2
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: gomod-backward-compatible
- dependency-name: k8s.io/apimachinery
  dependency-version: 0.34.2
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: gomod-backward-compatible
- dependency-name: k8s.io/client-go
  dependency-version: 0.34.2
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: gomod-backward-compatible
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Add Transit Options to Encrypt/Decrypt Helpers (#1156)

* add opts to transit, in order to add request params

* comments

* add test

* update transit signatures

* update test

* update test

* Bump github.com/gruntwork-io/terratest from 0.53.0 to 0.54.0 in the gomod-backward-compatible group (#1162)

Bump github.com/gruntwork-io/terratest

Bumps the gomod-backward-compatible group with 1 update: [github.com/gruntwork-io/terratest](https://github.com/gruntwork-io/terratest).


Updates `github.com/gruntwork-io/terratest` from 0.53.0 to 0.54.0
- [Release notes](https://github.com/gruntwork-io/terratest/releases)
- [Commits](gruntwork-io/terratest@v0.53.0...v0.54.0)

---
updated-dependencies:
- dependency-name: github.com/gruntwork-io/terratest
  dependency-version: 0.54.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: gomod-backward-compatible
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* CSI: ensure securityContext.privileged is true on the DaemonSet. (#1163)

Fixes a regression where the securityContext was moved to an enpty
value. The CSI driver requires that mountPropagation perms

* CSI: ensure securityContext.privileged is true on the driver container. (#1164)

Fixes a regression where the securityContext was moved to an enpty
value. The CSI driver requires that mountPropagation perms

Partially fixed in #1163

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Ben Ash <32777270+benashz@users.noreply.github.com>
Co-authored-by: Theron Voran <tvoran@users.noreply.github.com>
Co-authored-by: Michael Blaum <96261585+hashiblaum@users.noreply.github.com>
@benashz benashz added this to the v1.1.0 milestone Dec 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants