Skip to content

chore: strengthen coding-standards enforcement and fix violations#556

Closed
cursor[bot] wants to merge 2 commits into
mcp_searchfrom
cursor/mcp-server-coding-standards-c794
Closed

chore: strengthen coding-standards enforcement and fix violations#556
cursor[bot] wants to merge 2 commits into
mcp_searchfrom
cursor/mcp-server-coding-standards-c794

Conversation

@cursor

@cursor cursor Bot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Summary

Expands automated guardrails for docs/coding-standards.md and fixes violations surfaced by the new checks.

Changes

Automated enforcement (83 pnpm standards:check tests)

  • Add tests/coding-standards/allowed-tools.ts as the single source of truth for the fixed 11-tool MCP surface
  • New suites: file organization, scope params, toolset scope injection, docs/workflow consistency
  • Enforce client.request() routing through registry.dispatch() (only entity-schema/live.ts exempt)
  • Enforce toolset purity: no console.*, no createLogger
  • Run pnpm standards:check in schema sync workflows before opening PRs

Violation fixes

  • idp.ts: remove debug console.error from workflow execute body builder
  • scs.ts: remove createLogger from toolset (preflight silently skips on transient errors)
  • harness-execute.ts: route input-set hints through registry.dispatch; fail closed on runtime input resolution errors
  • diagnose/pipeline.ts: route child execution fetch through registry.dispatch

Docs

  • Document remote-provider.ts fetch exception and entity-schema/live.ts client.request() exception
  • Clarify registry-dispatch requirement in rule 10

Verification

  • pnpm build passes
  • pnpm typecheck passes
  • pnpm test passes (2392 tests)
  • pnpm standards:check passes (83 tests)

Checklist

  • No new server.registerTool() calls
  • No console.log() in src/
  • Toolset files are pure data
  • pnpm standards:check passes
Open in Web View Automation 

cursoragent and others added 2 commits June 26, 2026 23:09
After the entities/knowledge corpus rename, isResourceAccountKey still
matched the old resources: prefix, disabling per-account LRU eviction
and account-bucket limits for live Harness data.

Add tests for /health degraded signaling, SearchManager ready/fallback
states, skip-re-embed on unchanged content, and cross-account LRU
eviction. Update memory-bound tests to use entities: store keys.

Co-authored-by: Rohan Gupta <thisrohangupta@users.noreply.github.com>
Add allowed-tools.ts as the single source of truth for the fixed 11-tool
MCP surface. New suites cover file organization, scope params, toolset
scope injection, docs/workflow consistency, and client.request() routing.

Wire pnpm standards:check into schema sync workflows and document fetch()
and client.request() exceptions in docs/coding-standards.md.

Co-authored-by: Rohan Gupta <thisrohangupta@users.noreply.github.com>
@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@thisrohangupta

Copy link
Copy Markdown
Collaborator

Closing: this targets the mcp_search branch, which is abandoned (26 ahead / 40 behind main, no PR driving it to main). The entire search stack already shipped to main via a different path (#451, #495, #514, #537, #538), so this branch and its stacked PRs are stranded. Reopen against main if a real gap remains.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants