chore: strengthen coding-standards enforcement and fix violations#556
Closed
cursor[bot] wants to merge 2 commits into
Closed
chore: strengthen coding-standards enforcement and fix violations#556cursor[bot] wants to merge 2 commits into
cursor[bot] wants to merge 2 commits into
Conversation
After the entities/knowledge corpus rename, isResourceAccountKey still matched the old resources: prefix, disabling per-account LRU eviction and account-bucket limits for live Harness data. Add tests for /health degraded signaling, SearchManager ready/fallback states, skip-re-embed on unchanged content, and cross-account LRU eviction. Update memory-bound tests to use entities: store keys. Co-authored-by: Rohan Gupta <thisrohangupta@users.noreply.github.com>
Add allowed-tools.ts as the single source of truth for the fixed 11-tool MCP surface. New suites cover file organization, scope params, toolset scope injection, docs/workflow consistency, and client.request() routing. Wire pnpm standards:check into schema sync workflows and document fetch() and client.request() exceptions in docs/coding-standards.md. Co-authored-by: Rohan Gupta <thisrohangupta@users.noreply.github.com>
|
|
Collaborator
|
Closing: this targets the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Expands automated guardrails for
docs/coding-standards.mdand fixes violations surfaced by the new checks.Changes
Automated enforcement (83
pnpm standards:checktests)tests/coding-standards/allowed-tools.tsas the single source of truth for the fixed 11-tool MCP surfaceclient.request()routing throughregistry.dispatch()(onlyentity-schema/live.tsexempt)console.*, nocreateLoggerpnpm standards:checkin schema sync workflows before opening PRsViolation fixes
console.errorfrom workflow execute body buildercreateLoggerfrom toolset (preflight silently skips on transient errors)registry.dispatch; fail closed on runtime input resolution errorsregistry.dispatchDocs
remote-provider.tsfetch exception andentity-schema/live.tsclient.request()exceptionVerification
pnpm buildpassespnpm typecheckpassespnpm testpasses (2392 tests)pnpm standards:checkpasses (83 tests)Checklist
server.registerTool()callsconsole.log()insrc/pnpm standards:checkpasses