Skip to content

test: cover pipeline input-set override merge regressions (PR #532)#548

Draft
cursor[bot] wants to merge 5 commits into
mainfrom
cursor/missing-test-coverage-ee22
Draft

test: cover pipeline input-set override merge regressions (PR #532)#548
cursor[bot] wants to merge 5 commits into
mainfrom
cursor/missing-test-coverage-ee22

Conversation

@cursor

@cursor cursor Bot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Description

Adds missing regression tests for the pipeline input-set + inline override fix in PR #532 (substituteInputsIntoBaseYaml, resolveRuntimeInputsWithBaseYaml, and harness_execute combined path).

Risky behavior now covered

  • Variable identity by name: overrides update the correct pipeline variable when base YAML variable order differs from the runtime template, and append missing variables instead of writing by template list index.
  • Base input-set preservation: optional <+input>.default(...) placeholders are treated as covered when the materialized input set already supplies a value.
  • Fail-closed pre-flight with input sets: harness_execute blocks execution when input_set_ids + inline overrides still leave required fields uncovered (no execute API call).
  • Resolution metadata: successful combined runs expose _inputResolution.mode = "input_set_with_overrides".

Test files added/updated

  • tests/utils/runtime-input-resolver.test.ts — 7 new cases for substituteInputsIntoBaseYaml and resolveRuntimeInputsWithBaseYaml
  • tests/tools/tool-handlers.test.ts — 2 new harness_execute integration cases

Why these tests materially reduce regression risk

The original bug shipped because the combined input-set + override path skipped materialization and validation. These tests lock in the corrected merge semantics (name-based variable updates, base-value retention, and pre-flight blocking) at both the utility and public tool boundary.

Type of Change

  • Bug fix
  • New feature
  • Refactor
  • Documentation
  • Other — test coverage

Checklist

  • pnpm test passes (focused: 198 tests in touched files)
  • pnpm typecheck passes
  • pnpm build passes
  • pnpm standards:check passes
  • pnpm docs:check passes
Open in Web View Automation 

cursoragent and others added 5 commits July 1, 2026 11:08
Co-authored-by: Rohan Gupta <thisrohangupta@users.noreply.github.com>
Co-authored-by: Rohan Gupta <thisrohangupta@users.noreply.github.com>
Co-authored-by: Rohan Gupta <thisrohangupta@users.noreply.github.com>
Co-authored-by: Rohan Gupta <thisrohangupta@users.noreply.github.com>
Add focused tests for substituteInputsIntoBaseYaml variable identity
(reordered lists, appended variables, optional base coverage),
resolveRuntimeInputsWithBaseYaml, and harness_execute pre-flight
blocking plus input_set_with_overrides metadata.

Co-authored-by: Rohan Gupta <thisrohangupta@users.noreply.github.com>
@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants