test: cover pipeline input-set override merge regressions (PR #532)#548
Draft
cursor[bot] wants to merge 5 commits into
Draft
test: cover pipeline input-set override merge regressions (PR #532)#548cursor[bot] wants to merge 5 commits into
cursor[bot] wants to merge 5 commits into
Conversation
Co-authored-by: Rohan Gupta <thisrohangupta@users.noreply.github.com>
Co-authored-by: Rohan Gupta <thisrohangupta@users.noreply.github.com>
Co-authored-by: Rohan Gupta <thisrohangupta@users.noreply.github.com>
Co-authored-by: Rohan Gupta <thisrohangupta@users.noreply.github.com>
Add focused tests for substituteInputsIntoBaseYaml variable identity (reordered lists, appended variables, optional base coverage), resolveRuntimeInputsWithBaseYaml, and harness_execute pre-flight blocking plus input_set_with_overrides metadata. Co-authored-by: Rohan Gupta <thisrohangupta@users.noreply.github.com>
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds missing regression tests for the pipeline input-set + inline override fix in PR #532 (
substituteInputsIntoBaseYaml,resolveRuntimeInputsWithBaseYaml, andharness_executecombined path).Risky behavior now covered
<+input>.default(...)placeholders are treated as covered when the materialized input set already supplies a value.harness_executeblocks execution wheninput_set_ids+ inline overrides still leave required fields uncovered (no execute API call)._inputResolution.mode = "input_set_with_overrides".Test files added/updated
tests/utils/runtime-input-resolver.test.ts— 7 new cases forsubstituteInputsIntoBaseYamlandresolveRuntimeInputsWithBaseYamltests/tools/tool-handlers.test.ts— 2 newharness_executeintegration casesWhy these tests materially reduce regression risk
The original bug shipped because the combined input-set + override path skipped materialization and validation. These tests lock in the corrected merge semantics (name-based variable updates, base-value retention, and pre-flight blocking) at both the utility and public tool boundary.
Type of Change
Checklist
pnpm testpasses (focused: 198 tests in touched files)pnpm typecheckpassespnpm buildpassespnpm standards:checkpassespnpm docs:checkpasses