fix: enforce toolset purity and strengthen coding standards guardrails#528
Closed
cursor[bot] wants to merge 3 commits into
Closed
fix: enforce toolset purity and strengthen coding standards guardrails#528cursor[bot] wants to merge 3 commits into
cursor[bot] wants to merge 3 commits into
Conversation
Bump version to 3.2.5 across package.json, root and directory bundle manifests, and the release-metadata version contract test. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> AI-Session-Id: cc0246c6-f5e1-40f2-bf1a-6d8f3c6ba701 AI-Tool: claude-code AI-Model: unknown
- Remove createLogger from scs_remediation_pr preflight (silent fail-open on transient errors) - Ban createLogger imports and usage in toolset files via architecture guardrails - Document createLogger ban and remote-provider fetch exception in coding-standards.md Co-authored-by: Rohan Gupta <thisrohangupta@users.noreply.github.com>
|
|
- harness-execute fetchInputSetHint: use input_set list dispatch instead of client.request - diagnose/pipeline diagnoseChildPipeline: use execution get dispatch for child runs - Add architecture guardrail banning client.request in tool handlers (entity-schema/live exempt) - Update chained-pipeline diagnose test to mock registry.dispatch for child execution - Document client.request anti-pattern in coding-standards.md Co-authored-by: Rohan Gupta <thisrohangupta@users.noreply.github.com>
Collaborator
|
Closing: duplicate of the toolset-purity / ban-createLogger cluster. This intent already landed on Triaged as part of an open-PR cleanup pass. If this was mis-triaged, reopen and rebase onto current |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Compliance review against
docs/coding-standards.md(registry-driven MCP architecture).Findings
pnpm standards:checkguardrails passpnpm build,pnpm typecheck,pnpm docs:checkgreenharness_schemais the 11th; pasted 10-tool spec is outdated)import * as z from "zod/v4"), not v3Fix in this PR
src/registry/toolsets/scs.tsimportedcreateLoggerand logged from a toolset preflight hook — removed; 5xx/network preflight failures now fail open silently (behavior unchanged, logging moved out of toolset layer per standards)Guardrails strengthened
tests/coding-standards/architecture.test.tsnow forbidscreateLoggerimports and usage insrc/registry/toolsets/docs/coding-standards.mddocuments thecreateLoggerban andsearch/remote-provider.tsfetch exceptionType of Change
Checklist
pnpm testpassespnpm typecheckpassespnpm buildpassespnpm standards:checkpasses (architecture guardrails — see docs/coding-standards.md)pnpm docs:checkpasses (if registry/tool counts changed)Coding Standards (registry-driven MCP model)
server.registerTool()calls — only toolset definitions insrc/registry/toolsets/ALL_TOOLSETSandToolsetNameunionoperationPolicyon every new/changed endpointsrc/registry/extractors.ts(no raw passthrough on real endpoints)identifierFieldsandscopedeclared on new resourcesconsole.log()insrc/(stdio JSON-RPC safety)