Skip to content

fix(ci): accept 204 from the o11y deploy-event route #379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
demtario merged 1 commit into from
Sep 29, 2026
+4 −4
Merged

fix(ci): accept 204 from the o11y deploy-event route #379

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/master.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -324,7 +324,7 @@ jobs:
--data "{\"event\":\"deploy\",\"service\":\"handsontable-demos-authoring\",\"sha\":\"${GITHUB_SHA}\",\"cf_version_id\":\"${VERSION_ID}\"}") \
|| true
echo "deploy-event response: ${code:-<none>}"
[ "$code" = "200" ] || echo "::warning::deploy event for handsontable-demos-authoring did not return 200 (${code:-<none>})"
[ "$code" = "204" ] || [ "$code" = "200" ] || echo "::warning::deploy event for handsontable-demos-authoring did not return 204 (${code:-<none>})"

- name: Smoke test — prod frontend serves current bundle
working-directory: .
Expand Down Expand Up @@ -450,7 +450,7 @@ jobs:
--data "{\"event\":\"deploy\",\"service\":\"handsontable-demos-api\",\"sha\":\"${GITHUB_SHA}\",\"cf_version_id\":\"${VERSION_ID}\"}") \
|| true
echo "deploy-event response: ${code:-<none>}"
[ "$code" = "200" ] || echo "::warning::deploy event for handsontable-demos-api did not return 200 (${code:-<none>})"
[ "$code" = "204" ] || [ "$code" = "200" ] || echo "::warning::deploy event for handsontable-demos-api did not return 204 (${code:-<none>})"

- name: Smoke test — prod API health
working-directory: .
Expand Down Expand Up @@ -538,4 +538,4 @@ jobs:
--data "{\"event\":\"deploy\",\"service\":\"handsontable-demos-o11y\",\"sha\":\"${GITHUB_SHA}\",\"cf_version_id\":\"${VERSION_ID}\"}") \
|| true
echo "deploy-event response: ${code:-<none>}"
[ "$code" = "200" ] || echo "::warning::deploy event for handsontable-demos-o11y did not return 200 (${code:-<none>})"
[ "$code" = "204" ] || [ "$code" = "200" ] || echo "::warning::deploy event for handsontable-demos-o11y did not return 204 (${code:-<none>})"
2 changes: 1 addition & 1 deletion runner/docs/run-and-deploy.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -742,7 +742,7 @@ own stdout — `wrangler deploy` prints a trailing `Current Version ID: <uuid>`
line; capture it with `pnpm run deploy | tee deploy.log` (`set -o pipefail` is
on, so a piped deploy failure still fails the job) and
`grep -oE 'Current Version ID:.*' deploy.log | awk '{print $NF}'`. **This step
never fails the job on its own** (`-f` fails the curl on a non-2xx exit, but
never fails the job on its own** (the route answers `204` on success, and the warning fires for any other code; `-f` fails the curl on a non-2xx exit, but
its own exit code is deliberately not checked with `set -e` in force — a
warning line is emitted instead): a deploy that shipped correctly must not be
marked red because the *reporting* of it hiccuped, and on the very first
Expand Down
Loading