Skip to content

Updating prayer time api to aladhan.com for added functionality - #21

Open
a27med wants to merge 16 commits into
masterfrom
aladhan_api
Open

a27med wants to merge 16 commits into
masterfrom
aladhan_api

Conversation

@a27med

@a27med a27med commented Jun 2, 2018

Copy link
Copy Markdown
Collaborator

This change is Reviewable

@a27med
a27med requested a review from hamir June 2, 2018 20:50
@hamir

hamir commented Jun 3, 2018

Copy link
Copy Markdown
Owner

Review status: 0 of 8 files reviewed at latest revision, all discussions resolved, some commit checks failed.


aladhan_com_fetcher.py, line 59 at r1 (raw file):

    elif country.lower() == 'qatar':
      #Qatar
      return 10

make these an enum?


aladhan_com_fetcher.py, line 143 at r1 (raw file):

      continue

  #print 'here = ', request.text

remove these prints here and elsewhere?


Comments from Reviewable

@hamir

hamir commented Jun 3, 2018

Copy link
Copy Markdown
Owner

:lgtm:


Review status: 4 of 8 files reviewed at latest revision, 2 unresolved discussions.


Comments from Reviewable

@a27med

a27med commented Jun 4, 2018

Copy link
Copy Markdown
Collaborator Author

Review status: 1 of 10 files reviewed at latest revision, 2 unresolved discussions, some commit checks failed.


aladhan_com_fetcher.py, line 59 at r1 (raw file):

Previously, hamir wrote…

make these an enum?

Done.


aladhan_com_fetcher.py, line 143 at r1 (raw file):

Previously, hamir wrote…

remove these prints here and elsewhere?

Done.


Comments from Reviewable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants