Conversation
The disabled HTML attribute already accounted for isLoading, but aria-disabled only reflected the disabled prop. Screen reader users could be told a loading button was still interactive. Fall back to undefined when neither disabled nor isLoading is set so the attribute is omitted in the default case, matching prior behavior.
Add a regression test asserting the rendered button has aria-disabled="true" while isLoading is true, even without an explicit disabled prop.
zigzagdev
requested review from
a team,
flaviafmoraes,
matheus-wh and
wellhub-gsevla
as code owners
September 6, 2026 13:58
aria-disabled
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📄
[Enter the description of your changes]
The
disabledHTML attribute onButtonalready accounted forisLoading(disabled={disabled || isLoading}), butaria-disabledonly reflected thedisabledprop.Screen reader users could be told a loading button was still interactive.
Updated
aria-disabledto also reflectisLoading, falling back toundefinedwhen neitherdisablednorisLoadingis set so the attribute is omitted in the default case, matching prior behavior.Platforms 📲
Type of change 🔍
How Has This Been Tested? 🧪
[Enter the tips to test this PR]
Added a regression test asserting the rendered button has
aria-disabled="true"whileisLoadingis true, even without an explicitdisabledprop.Ran the full
Buttontest suite locally — all 146 tests pass; 34 pre-existing "Loading" snapshots were updated to include the newaria-disabled="true"attribute, and no other snapshots changed.Checklist: 🔍
Screenshots 📸
[Upload your screenshots here]
N/A