Skip to content

feat(icons): [CIB-4815] add Ticket icon - #962

Merged
flaviafmoraes merged 1 commit into
masterfrom
CIB-4815
Sep 1, 2026
Merged

flaviafmoraes merged 1 commit into
masterfrom
CIB-4815

Conversation

@leonardobrombilla

@leonardobrombilla leonardobrombilla commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

JIRA Issue

Description 📄

Adds a new SVG icon to the @gympass/yoga-icons package and exports it from ui.ts:

  • Ticket

Used by the Extra check-in tag on the booking card. It follows the 12×12 viewBox convention with a single <path> and no hardcoded color, so it can be fully controlled via the fill prop on the <Icon> component.

Task figma link: https://www.figma.com/design/jtjRkATXpAXifKscRXjd1z/-Check-in---Booking--Extra-Check-in?node-id=10407-71132&m=dev

Platforms 📲

  • Web
  • Mobile

Type of change 🔍

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested? 🧪

Rendered the icon locally through the <Icon> component on the docs site (/components/icon) with different fill color tokens (default, stamina, energy, hope, vibin) and a raw hex value, and at every size token (xsmallxlarge) to confirm fill inheritance and scaling work correctly.

The SVG has a single <path> with no hardcoded fill and no fill="none" on the <svg> root, so any color passed through <Icon fill="..." /> is correctly applied.

  • Unit Test
  • Snapshot Test

Checklist: 🔍

  • My code follows the contribution guide of this project Contributing Guide
  • Layout matches design prototype: FIGMA
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Screenshots 📸

Icon

Size test

Captura de Tela 2026-09-01 às 15 10 35

Fill color test

Captura de Tela 2026-09-01 às 15 10 35

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@sonarqubecloud

sonarqubecloud Bot commented Sep 1, 2026

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
5 Security Hotspots
C Security Rating on New Code (required ≥ A)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@wellhub-gsevla wellhub-gsevla left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for your contribution!

@flaviafmoraes
flaviafmoraes merged commit 7c7d52a into master Sep 1, 2026
2 of 3 checks passed
@flaviafmoraes
flaviafmoraes deleted the CIB-4815 branch September 1, 2026 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants