Conversation
korikuzma
commented
Jun 24, 2026
susannasiebert
previously approved these changes
Jun 29, 2026
susannasiebert
left a comment
susannasiebert
left a comment
Collaborator
There was a problem hiding this comment.
+1 once tests pass
Collaborator
Author
|
@ahwagner changed his mind lol. Changing system back to URL |
korikuzma
commented
Jun 29, 2026
aw wants this
Collaborator
Author
|
@susannasiebert re-requesting review since Alex changed his mind in a call last evening about using URL for system rather than free-text |
Collaborator
Author
|
@susannasiebert @acoffman Not sure if you wanted to re-review since there were some changes in how Alex wanted to represent the mapping |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #232
Will open once ga4gh/va-spec#404 is approved (making sure system value is okay)