docs: [DOC] Update doc to reflect thread sampling logic required for tracin...#5238
Open
arnavnagzirkar wants to merge 2 commits into
Open
docs: [DOC] Update doc to reflect thread sampling logic required for tracin...#5238arnavnagzirkar wants to merge 2 commits into
arnavnagzirkar wants to merge 2 commits into
Conversation
|
|
1 similar comment
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In
StackSamplerLoop::MainLoopIteration()(pyroscope-dotnet), theCodeHotspotIteration()function - which samples threads that carry a trace context and is the core of the trace-span profiles integration - is only called inside theIsWallTimeProfilingEnabled()guard: if...Root cause
In
StackSamplerLoop::MainLoopIteration()(pyroscope-dotnet), theCodeHotspotIteration()function - which samples threads that carry a trace context and is the core of the trace-span profiles integration - is only called inside theIsWallTimeProfilingEnabled()guard:PYROSCOPE_PROFILING_WALLTIME_ENABLEDdefaults tofalse, so users enabling the .NET tracing integration without explicitly turning on walltime profiling will get no profile data linked to their spans. This dependency was not documented anywhere.What changed
docs/sources/configure-client/trace-span-profiles/dotnet-span-profiles.mdPYROSCOPE_PROFILING_WALLTIME_ENABLED=1.docs/sources/configure-client/language-sdks/dotnet.mdPYROSCOPE_PROFILING_WALLTIME_ENABLEDrow in the configuration table to note it is required for the tracing integration, with a link to the span profiles doc.Issue
Fixes #3482
Issue: #3482
Diffstat
Testing
Ran the relevant tests and linter for the changed files while developing.
Kept the change minimal and focused on this one issue.
AI assistance
I used GitHub Copilot to help write parts of this change. I've reviewed and tested it myself, I understand what it does, and I'll follow up on any review feedback.