feat: add mapping names to Flamegraph#5201
Open
elizaveta-andreeva wants to merge 1 commit into
Open
Conversation
|
e.andreeva seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
This was referenced May 28, 2026
de9c5a0 to
6cce742
Compare
6cce742 to
1e8182a
Compare
Author
|
@korniltsev-grafanista could you take a look pls? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds filename/mapping information to the Flamegraph response, enabling Grafana to apply custom coloring schemes based on kernel/user space symbols. The mapping data exposes the executable for each symbol, allowing Grafana to identify which binary or library a frame belongs to.
Changes
Proto changes:
mapping_namesfield ([]string) toFlameGraphandTreeReportproto messagesmappingfield (map<function_name, filename>) toSelectMergeStacktracesResponseandSelectMergeSpanProfileResponseproto messagesResolver:
TreeWithMappings()method toResolverthat builds afunction name -> filenamemapping from symbol dataFlameGraph construction:
mapping_namesinNewFlameGraph()using the mapping built abovequeryTree->TreeReport->SelectMergeStacktracesResponse/SelectMergeSpanProfileResponsepprof / OTLP:
buildMappingFromPprof()andbuildMappingFromProfile()helpers to extract mapping from pprof profiles (pprof->profile->mapping)frameTypeto distinguish user vs. kernel space symbols when converting OTLP to Google profile format[kernel]prefix to kernel symbol mapping filenames during OTLP conversion, so that Grafana can correctly classify and color kernel framesTests:
Related PR: grafana/grafana#125627